Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Maven Wrapper #220

Merged
merged 1 commit into from
Sep 8, 2021
Merged

Adds Maven Wrapper #220

merged 1 commit into from
Sep 8, 2021

Conversation

mathieucarbou
Copy link
Owner

No description provided.

@mathieucarbou mathieucarbou added this to the 4.2 milestone Sep 8, 2021
@mathieucarbou mathieucarbou self-assigned this Sep 8, 2021
@mathieucarbou mathieucarbou added in:build MLP build system (maven) is:feature New feature labels Sep 8, 2021
@rremer
Copy link

rremer commented Sep 8, 2021

FYI that you don't want to commit the jarfile or the java, just the properties file and the wrapper scripts mvnw and mvnw.cmd

@mathieucarbou
Copy link
Owner Author

FYI that you don't want to commit the jarfile or the java, just the properties file and the wrapper scripts mvnw and mvnw.cmd

thanks!

@mathieucarbou
Copy link
Owner Author

Damn! I don't have any Travi-ci credits anymore :-(

.gitignore Outdated
@@ -26,3 +26,5 @@ nb-configuration.xml
# OSX
.DS_Store
release-pom.xml

/.mvn/wrapper/maven-wrapper.jar
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you'll want to add probably .mvn/wrapper/*.ja to capture any named jar or java files in here, and then delete MavenWrapperDownloader.java from this branch as well

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finally I had to commit the file because of an error in Travis build:

--2021-09-08 21:03:25--  https://repo.maven.apache.org/maven2/io/takari/maven-wrapper/0.5.6/maven-wrapper-0.5.6.jar
Resolving repo.maven.apache.org (repo.maven.apache.org)... 199.232.192.215, 199.232.196.215
Connecting to repo.maven.apache.org (repo.maven.apache.org)|199.232.192.215|:443... connected.
ERROR: cannot verify repo.maven.apache.org's certificate, issued by 'CN=GlobalSign Atlas R3 DV TLS CA H2 2021,O=GlobalSign nv-sa,C=BE':
  Unable to locally verify the issuer's authority.
To connect to repo.maven.apache.org insecurely, use `--no-check-certificate'.

@mathieucarbou
Copy link
Owner Author

mathieucarbou commented Sep 8, 2021

Damn! I don't have any Travi-ci credits anymore :-(

Thanks @erikakuntar for the @travis-ci OSS credits!

@mathieucarbou mathieucarbou merged commit 0081dcd into master Sep 8, 2021
@mathieucarbou mathieucarbou deleted the wrapper branch September 11, 2021 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in:build MLP build system (maven) is:feature New feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants