Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added provider of author name and email address obtained from first commit #155

Merged
merged 5 commits into from
Jun 5, 2020

Conversation

masakimu
Copy link
Contributor

@masakimu masakimu commented Oct 1, 2019

Hi, I'm a user of your license maven plugin and git plugin.

I wanted to insert original author name and email address into license headers using git history,
so I made following patch for git plugin:

  • added CopyrightAuthorProvider to treat author information of first commit
  • modified GitLookup.java to obtain author information from git history
  • separated getGitLookup method from CopyrightRangeProvider to GitPropertiesProvider base class.
  • added unit test of CopyrightAuthorProvider

Could you review this PR when you're available?

Thank you.

@masakimu masakimu mentioned this pull request Oct 1, 2019
@mathieucarbou mathieucarbou added this to the 4.0 milestone Jun 5, 2020
@mathieucarbou mathieucarbou merged commit e4675b6 into mathieucarbou:master Jun 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants