[java] Cleanup isAllowed method as it can be much more simple

mathieucarbou · Feb 14, 2023 · 415e750 · 415e750
1 parent 392b51e
commit 415e750
Showing 1 changed file with 2 additions and 8 deletions.
diff --git a/...aven-plugin/src/main/java/com/mycila/maven/plugin/license/dependencies/LicensePolicy.java b/...aven-plugin/src/main/java/com/mycila/maven/plugin/license/dependencies/LicensePolicy.java
@@ -51,16 +51,10 @@ public boolean getPredicate() {
      * Simple policy decision based on whether a matcher succeeded.
      *
      * @param matched - boolean result of some matching operation.
-     * @return
+     * @return true, if is allowed
      */
     public boolean isAllowed(final boolean matched) {
-      if (matched && allowed) {
-        return true;
-      } else if (!matched && !allowed) {
-        return true;
-      } else {
-        return false;
-      }
+      return (matched && allowed) || (!matched && !allowed);
     }
 
     public static Rule valueOf(final boolean allowed) {