Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BAD_NETWORK #11 issue solved #18

Merged
merged 3 commits into from
Jun 27, 2017
Merged

BAD_NETWORK #11 issue solved #18

merged 3 commits into from
Jun 27, 2017

Conversation

arthurlacoste
Copy link
Contributor

No description provided.

@FranklinChen
Copy link

Can the test be fixed here and this branch be merged?

@StephanBijzitter
Copy link

#16 contains this fix, including fixed test case

@scottie
Copy link

scottie commented May 4, 2017

when will this me merged to NPM ??

@coveralls
Copy link

Coverage Status

Coverage remained the same at 90.909% when pulling df4f369 on arthurlacoste:master into 52d2f74 on matheuss:master.

1 similar comment
@coveralls
Copy link

coveralls commented May 5, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 90.909% when pulling df4f369 on arthurlacoste:master into 52d2f74 on matheuss:master.

@codecov-io
Copy link

codecov-io commented May 5, 2017 •
edited
Loading

Codecov Report

Merging #18 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master     #18   +/-   ##
======================================
  Coverage    90.9%   90.9%           
======================================
  Files           2       2           
  Lines          66      66           
======================================
  Hits           60      60           
  Misses          6       6
Impacted Files Coverage Δ
languages.js 100% <ø> (ø) ⬆️
index.js 88.23% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 52d2f74...022246c. Read the comment docs.

@arthurlacoste
Updating languages.js
022246c 
- Adding Amharic
- Correct error (Sudanese > Sundanese)

Following this page :
https://cloud.google.com/translate/docs/languages
@coveralls
Copy link

Coverage Status

Coverage remained the same at 90.909% when pulling 022246c on arthurlacoste:master into 52d2f74 on matheuss:master.

@coveralls
Copy link

coveralls commented May 6, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 90.909% when pulling df4f369 on arthurlacoste:master into 52d2f74 on matheuss:master.

@jacksteamdev jacksteamdev mentioned this pull request May 6, 2017
Closed
@ATheCoder
Copy link

Why hasn't this been added to the NPM installation?

@JukeboxRhino JukeboxRhino merged commit e1e923d into matheuss:master Jun 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@arthurlacoste @FranklinChen @StephanBijzitter @scottie @coveralls @codecov-io @ATheCoder @aman-raikwar @JukeboxRhino