Skip to content

Commit

Permalink
lnrpc: ignore legacy onion payload as an option for SendToRoute
Browse files Browse the repository at this point in the history
In this commit, we start to ignore the option to allow the caller to use
the legacy onion payload. The new payload is much more flexible and
efficient, so there's really no reason to still use it, other than for
backwards compatibility tests. Our existing tests that exercise the
legacy feature uses a build tag, which forces nodes to not advertise the
new payload format, which then forces path finding to include the legacy
payload, so we can be confident that route is still being tested.

The existence of this option (which actually makes the TLV payload
opt-in for `SendToRoute` users) makes it harder to remove it from the
protocol all together. With this PR, we take a step forward to allowing
such a change which is being tracked on the spec level at:
lightning/bolts#962.

In a future release, we'll move to remove the field all together.
Ignoring the field today doesn't seem to have any clear downsides, as
most payments always include the MPP payload (due to payment secrets),
so this shouldn't impact users in a significant way.
  • Loading branch information
Roasbeef authored and matheusd committed Feb 12, 2024
1 parent e10acf0 commit ff0ea7d
Show file tree
Hide file tree
Showing 3 changed files with 1,436 additions and 1,433 deletions.
Loading

0 comments on commit ff0ea7d

Please sign in to comment.