Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hahn decomposition theorem #777

Merged
merged 1 commit into from
Apr 21, 2023
Merged

Conversation

affeldt-aist
Copy link
Member

@affeldt-aist affeldt-aist commented Oct 18, 2022

  • introduces signed measures

Co-authored-by: IshiguroYoshihiro

based on PR #836 (has been merged into master)

Motivation for this change
Things done/to do
  • added corresponding entries in CHANGELOG_UNRELEASED.md
  • added corresponding documentation in the headers
Automatic note to reviewers

Read this Checklist and put a milestone if possible.

@affeldt-aist affeldt-aist changed the title tentative proof of Hahn decomposition theorem Hahn decomposition theorem Jan 3, 2023
@affeldt-aist affeldt-aist mentioned this pull request Jan 3, 2023
2 tasks
@affeldt-aist affeldt-aist force-pushed the smeasure branch 2 times, most recently from 11bdaa1 to 2cfbef6 Compare February 6, 2023 00:32
@affeldt-aist affeldt-aist mentioned this pull request Feb 6, 2023
2 tasks
@affeldt-aist affeldt-aist marked this pull request as ready for review February 6, 2023 12:49
@affeldt-aist affeldt-aist force-pushed the smeasure branch 4 times, most recently from 28db4cd to 3f94ae7 Compare February 15, 2023 06:40
@affeldt-aist affeldt-aist added this to the 0.6.2 milestone Feb 23, 2023
@affeldt-aist affeldt-aist requested a review from t6s March 15, 2023 14:27
@affeldt-aist affeldt-aist added the enhancement ✨ This issue/PR is about adding new features enhancing the library label Mar 15, 2023
@affeldt-aist affeldt-aist force-pushed the smeasure branch 2 times, most recently from 7ccf660 to cbba235 Compare March 19, 2023 00:12
@affeldt-aist
Copy link
Member Author

@IshiguroYoshihiro could you also take a look?

@CohenCyril CohenCyril added the TODO: MC2 port This PR must be ported to mathcomp 2 now that the. Remove this label when the port is done. label Mar 27, 2023
@affeldt-aist
Copy link
Member Author

@IshiguroYoshihiro could you also take a look?

ping

@affeldt-aist affeldt-aist requested review from t6s and removed request for t6s April 7, 2023 05:23
@affeldt-aist
Copy link
Member Author

ping @IshiguroYoshihiro @t6s

@affeldt-aist affeldt-aist requested a review from t6s April 11, 2023 22:38
Copy link
Contributor

@zstone1 zstone1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look pretty good, actually. I haven't gone through the proofs in too much detail. But they look, more-or-less, aligned with the textbook proofs. While I'm sure there are probably improvements in there, I'm not too worried about it. Qed is Qed.

What interests me is the use of FinNumFun. It actually causes some headache later, with mine_cvg_0_cvg_0. That proof is pretty easy in R because _ * 2 and min (_,1) are both trivially continuous. It's annoying to have to reprove all this in \bar R. I would love to see

  1. Somehow support this kind of sorta-heterogeneous types in the definition of this hierarchy.
  2. Transport the goal from \bar R to R. This seems much more plausible. We could do it ad-hoc, by showing fine is a homeomorphism on the image of (fun n => mine (x n * (2^-1)%:E) 1). But it should be possible to do this more generically.

This is not a dealbreaker for merging the PR. I'm mostly just recording this discomfort. This is something always brushed under the rug in textbooks, so no surprise we gotta deal with it here.

@affeldt-aist
Copy link
Member Author

Indeed, it is pretty frustrating to have this proof (mine_cvg_0_cvg_0) that literally embeds the proof for the case in R...

@affeldt-aist
Copy link
Member Author

affeldt-aist commented Apr 20, 2023

In the last commit b674879 I split the lemma mine_cvg_0_cvg_0 into pieces so that it isolates the subcase about R. It is a bit longer but hopefully it will be easier to handle when we'll figure out how to generalize. I'll issue about that upon merging.

@affeldt-aist affeldt-aist force-pushed the smeasure branch 2 times, most recently from 493a1fa to 5140460 Compare April 21, 2023 01:45
- introduces signed measures/charges

Co-authored-by: IshiguroYoshihiro
@affeldt-aist affeldt-aist merged commit 91476c4 into math-comp:master Apr 21, 2023
affeldt-aist added a commit that referenced this pull request Apr 21, 2023
- introduces signed measures/charges

Co-authored-by: IshiguroYoshihiro
@proux01 proux01 removed the TODO: MC2 port This PR must be ported to mathcomp 2 now that the. Remove this label when the port is done. label Apr 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement ✨ This issue/PR is about adding new features enhancing the library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants