Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes #613 (funennp naming) #624

Merged
merged 2 commits into from
May 2, 2022
Merged

fixes #613 (funennp naming) #624

merged 2 commits into from
May 2, 2022

Conversation

affeldt-aist
Copy link
Member

@affeldt-aist affeldt-aist commented Apr 1, 2022

Motivation for this change

fixes #613

also contains minor proof simplifications

following discussion during the last meeting

Things done/to do
  • added corresponding entries in CHANGELOG_UNRELEASED.md
    - [ ] added corresponding documentation in the headers
Automatic note to reviewers

Read this Checklist and put a milestone if possible.

@affeldt-aist affeldt-aist changed the title fixes #613 fixes #613 (funennp naming) Apr 1, 2022
@affeldt-aist affeldt-aist force-pushed the fixes_613 branch 2 times, most recently from 6e3896f to 88b11bb Compare April 13, 2022 01:36
@affeldt-aist affeldt-aist requested a review from ybertot April 13, 2022 01:36
@affeldt-aist affeldt-aist requested review from ybertot and removed request for ybertot April 19, 2022 23:39
@affeldt-aist affeldt-aist added this to the 0.5.1 milestone Apr 22, 2022
@affeldt-aist affeldt-aist force-pushed the fixes_613 branch 2 times, most recently from 552ef08 to e00d430 Compare April 25, 2022 12:25
@affeldt-aist
Copy link
Member Author

Since it is essentially a renaming discussed in the meeting, we may consider it as good to go?

@affeldt-aist
Copy link
Member Author

@ybertot ping?

Copy link
Member

@ybertot ybertot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. There are two minor problems that I think should be corrected.

affeldt-aist and others added 2 commits May 2, 2022 23:04
Co-authored-by: Yves Bertot <Yves.Bertot@inria.fr>
@affeldt-aist
Copy link
Member Author

This looks good to me. There are two minor problems that I think should be corrected.

Indeed. Thank you!

@affeldt-aist affeldt-aist merged commit d637864 into master May 2, 2022
@affeldt-aist affeldt-aist deleted the fixes_613 branch May 2, 2022 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix name
2 participants