Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ereals form a pseudometric type #215

Merged
merged 6 commits into from
Jun 10, 2020
Merged

ereals form a pseudometric type #215

merged 6 commits into from
Jun 10, 2020

Conversation

affeldt-aist
Copy link
Member

@affeldt-aist affeldt-aist commented May 29, 2020 •
edited
Loading

warning:

@affeldt-aist affeldt-aist marked this pull request as draft May 29, 2020 13:44
@affeldt-aist affeldt-aist changed the title ereals from a pseudometric type ereals form a pseudometric type May 29, 2020
@affeldt-aist affeldt-aist changed the base branch from master to supremums_ereal May 29, 2020 14:16
CohenCyril
CohenCyril reviewed May 29, 2020
View reviewed changes
CohenCyril
CohenCyril reviewed May 31, 2020
View reviewed changes
CohenCyril
CohenCyril reviewed Jun 2, 2020
View reviewed changes
@affeldt-aist affeldt-aist changed the base branch from supremums_ereal to master June 3, 2020 11:05
@affeldt-aist affeldt-aist added this to the 0.3.1 milestone Jun 8, 2020
@affeldt-aist affeldt-aist marked this pull request as ready for review June 8, 2020 23:53
CohenCyril
CohenCyril reviewed Jun 9, 2020
View reviewed changes
CohenCyril
CohenCyril approved these changes Jun 10, 2020
View reviewed changes
Copy link
Member

@CohenCyril CohenCyril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, the proofs look a bit long to me, but we can refactor later!

@CohenCyril CohenCyril merged commit 5c8f6d8 into master Jun 10, 2020
@CohenCyril CohenCyril deleted the ereal_pseudometric branch June 10, 2020 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CohenCyril CohenCyril CohenCyril approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.3.1
Development

Successfully merging this pull request may close these issues.
2 participants
@affeldt-aist @CohenCyril