Make algebra_tactics robust to attacks on the algebraic hierarchy #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
CohenCyril
reviewed
Jan 20, 2025
theories/common.v
Outdated
| @@ -1393,5 +1393,6 @@ pred canonical-Z-semiring o:constant. | |||
| pred canonical-Z-ring o:constant. | |||
| pred canonical-Z-comring o:constant. | |||
| pred canonical-Z-unitring o:constant. | |||
| pred coercion i:string o:term. | |||
There was a problem hiding this comment.
In Db we should have only outputs (I thought elpi was complaining about this ...)
|
@pi8027 this should be resilient to changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The algebraic hierarchy keeps changing, so we compute the coercions that need to be inserted in the arguments of the constants in GRing. This computation is done at compile-time so that it does not slow down the execution of the tactics.
This should subsume #100 and #106.