Recover commented out code in tests and mark with pytest.mark.skip
instead
#4027
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
pytest.mark.skip
instead (withTODO: need someone to fix this
message for easy search), though currentlyERA
is ignored:pymatgen/pyproject.toml
Line 192 in c06abf1
Rationale
Commented out code ages badly if not covered by any linter, perhaps we should mark them with
pytest.mark.skip
instead until someone come and fix them (hopefully).