-
Notifications
You must be signed in to change notification settings - Fork 875
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove the skip
mark for test_delta_func
#4014
Conversation
Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
All windows tests have passed. |
Thanks for keeping an eye on this, perhaps we should bump Line 68 in 41e4c69
|
I bump it for Windows only. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @njzjz, just a nitpick to address
@@ -66,6 +66,7 @@ dependencies = [ | |||
"requests>=2.32", | |||
"ruamel.yaml>=0.17.0", | |||
"scipy>=1.13.0", | |||
"scipy>=1.14.1; platform_system == 'Windows'", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@njzjz can you add a comment linking to scipy/scipy#21052 to explain the platform-dependent version pin?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added in d6a0b5a
skip
mark for test_delta_func
Summary
scipy/scipy#21052 has been fixed and released in scipy 1.14.1. This PR removes the skip mark.
Todos
If this is work in progress, what else needs to be done?
Checklist
ruff
.mypy
.duecredit
@due.dcite
decorators to reference relevant papers by DOI (example)Tip: Install
pre-commit
hooks to auto-check types and linting before every commit: