Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the skip mark for test_delta_func #4014

Merged
merged 6 commits into from
Aug 29, 2024
Merged

Conversation

njzjz
Copy link
Contributor

@njzjz njzjz commented Aug 23, 2024

Summary

scipy/scipy#21052 has been fixed and released in scipy 1.14.1. This PR removes the skip mark.

Todos

If this is work in progress, what else needs to be done?

  • feature 2: ...
  • fix 2:

Checklist

  • Google format doc strings added. Check with ruff.
  • Type annotations included. Check with mypy.
  • Tests added for new features/fixes.
  • If applicable, new classes/functions/modules have duecredit @due.dcite decorators to reference relevant papers by DOI (example)

Tip: Install pre-commit hooks to auto-check types and linting before every commit:

pip install -U pre-commit
pre-commit install

Signed-off-by: Jinzhe Zeng <jinzhe.zeng@rutgers.edu>
@njzjz
Copy link
Contributor Author

njzjz commented Aug 23, 2024

All windows tests have passed.

@DanielYang59
Copy link
Contributor

DanielYang59 commented Aug 24, 2024

Thanks for keeping an eye on this, perhaps we should bump scipy version also (to >=1.14.1)?

"scipy>=1.13.0",

@janosh janosh added tests Issues with or changes to the pymatgen test suite windows Windows-specific issues labels Aug 24, 2024
@njzjz
Copy link
Contributor Author

njzjz commented Aug 24, 2024

perhaps we should bump scipy version also (to >=1.14.1)?

I bump it for Windows only.

Copy link
Member

@janosh janosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @njzjz, just a nitpick to address

@@ -66,6 +66,7 @@ dependencies = [
"requests>=2.32",
"ruamel.yaml>=0.17.0",
"scipy>=1.13.0",
"scipy>=1.14.1; platform_system == 'Windows'",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@njzjz can you add a comment linking to scipy/scipy#21052 to explain the platform-dependent version pin?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added in d6a0b5a

@janosh janosh merged commit df25dfa into materialsproject:master Aug 29, 2024
42 checks passed
@janosh janosh changed the title Remove the skip mark for test_delta_func Remove the skip mark for test_delta_func Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Issues with or changes to the pymatgen test suite windows Windows-specific issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants