-
Notifications
You must be signed in to change notification settings - Fork 875
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add modification to aims input to match atomate2 magnetic order script #3878
Conversation
How it deals with spins is not through magmoms, but FHI-aims uses magmoms exclusively
Standardize the inputs handeling of magmoms and spin in the sepecies
1) Parse mulliken inpformation 2) Better standardize relaxation final chunk Done because mulliken analysis only happens for the final structure and after the normal parsing line is stated
this parsing is now working
changes in parsing added a new property key (n_iter)
…into magnetism_aims
this is the way FHI-aims reccommends to do it, but it is not the most accurate approximations
Signed-off-by: Thomas Purcell <purcellt@arizona.edu>
ready for review |
Thanks for the PR @tpurcell90, can you expand on:
I'm not sure I understand, apologies. |
Signed-off-by: Thomas Purcell <purcellt@arizona.edu>
Can this be merged in? |
Test passed locally will check if they pass here ready for review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor nitpicks
Co-authored-by: Janosh Riebesell <janosh.riebesell@gmail.com> Signed-off-by: Thomas Purcell <purcellt@arizona.edu>
Co-authored-by: Janosh Riebesell <janosh.riebesell@gmail.com> Signed-off-by: Thomas Purcell <purcellt@arizona.edu>
Co-authored-by: Janosh Riebesell <janosh.riebesell@gmail.com> Signed-off-by: Thomas Purcell <purcellt@arizona.edu>
Co-authored-by: Janosh Riebesell <janosh.riebesell@gmail.com> Signed-off-by: Thomas Purcell <purcellt@arizona.edu>
Remove stray \ replace split(",spin") with re.sub(",spin=F", "") with label
Evaluatlion of array error
I should have incorporated all of the suggestions from @janosh |
Thanks for your patience during review @tpurcell90, appreciate your PR! |
missed a few typos in my review. fixed in 149e115. @tpurcell90 I noticed that it might make more sense to turn pymatgen/src/pymatgen/io/aims/inputs.py Lines 708 to 737 in 149e115
|
I made it a dataclass in a separate PR |
How it deals with spins is not through magmoms, but FHI-aims uses magmoms exclusively
Summary
Modifying FHI-aims inputs to work with the magnetism workflows in atomate2
Todos
If this is work in progress, what else needs to be done?
Checklist
ruff
.mypy
.duecredit
@due.dcite
decorators to reference relevant papers by DOI (example)Tip: Install
pre-commit
hooks to auto-check types and linting before every commit: