Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zopen: add explicit encoding to read_json; explicit mode #1030

Merged
merged 2 commits into from
Feb 6, 2025

Conversation

rkingsbury
Copy link
Collaborator

@rkingsbury rkingsbury commented Feb 6, 2025

Add explicit mode and encoding arguments to all zopen calls, to avoid warnings associated with recent monty changes.

See materialsvirtuallab/monty#730

Copy link

codecov bot commented Feb 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.91%. Comparing base (0fddbc2) to head (02520e8).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1030   +/-   ##
=======================================
  Coverage   88.91%   88.91%           
=======================================
  Files          46       46           
  Lines        3997     3997           
=======================================
  Hits         3554     3554           
  Misses        443      443           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rkingsbury rkingsbury merged commit 691ebf4 into materialsproject:main Feb 6, 2025
10 checks passed
@rkingsbury rkingsbury deleted the zopen branch February 6, 2025 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant