FIX: Properly jsanitize fireworks Task

[gpetretto]

I have seen that in some cases the JobFiretask does not properly serialize a Job.
Consider the case of a Maker with a Callable as an attribute.

from fireworks import LaunchPad
from jobflow.managers.fireworks import job_to_firework

from dataclasses import dataclass
from typing import Callable
from jobflow import Maker, job


def print_function():
    print("TEST")


@dataclass
class CallableMaker(Maker):
    f: Callable
    name: str = "CallableMaker"

    @job
    def make(self, *args, **kwargs):
        self.f()

j = CallableMaker(f=print_function).make()

fw = job_to_firework(j)
lpad = LaunchPad.auto_load()
lpad.add_wf(fw)

When running this, in the firework DB you have

{
    "spec": {
        "_tasks": [
            {
                "job": {
                    "@module": "jobflow.core.job",
                    "@class": "Job",
                    "@version": "0.1.14.post122+g6439853",
                    "function": {
                        "@module": "__main__",
                        "@callable": "CallableMaker.make",
                        "@bound": {
                            "@module": "__main__",
                            "@class": "CallableMaker",
                            "@version": null,
                            "f": "<function print_function at 0x16ad82cb0>",
                            "name": "CallableMaker"
                        }
                    },
                   ...

}

Where the function is serialized as a string.

This PR addresses this issue by overriding the JobFiretask.to_dict method and explicitly jsanitizing the Job.

[utf]

Great catch! Thanks @gpetretto

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c211030) 99.42% compared to head (0debb38) 99.42%.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #544   +/-   ##
=======================================
  Coverage   99.42%   99.42%           
=======================================
  Files          21       21           
  Lines        1556     1564    +8     
  Branches      422      425    +3     
=======================================
+ Hits         1547     1555    +8     
  Misses          9        9           

Files	Coverage Δ
src/jobflow/managers/fireworks.py	100.00% <100.00%> (ø)

[utf]

Is it possible to add a quick test?

[gpetretto]

Is it possible to add a quick test?

done

[utf]

Perfect, thanks so much.