Explicit warning stacklevels #503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
janosh
added
docs
|
1st attempt at CI link checking in ffc23cb using https://github.com/jupyterlab/pytest-check-links which supports Jupyter notebooks. Never used it before but it's from jupyterlab and looks official. |
janosh
force-pushed
the
explicit-warning-stacklevels
branch
2 times, most recently
from
2af76f8 to
913a107
Compare
janosh
force-pushed
the
explicit-warning-stacklevels
branch
from
f40e755 to
7666ca6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
d80f17d unpin and update pre-commit hooks
3f607e1 add explicit stacklevel to warnings (fixes flake8 B028)
d3c690d fix dead dynamic wf doc link reported in openjournals/joss-reviews#5995 (comment)
See here for rational behind explicit stack levels.
@utf @Andrew-S-Rosen We should probably add a link checker CI to catch dead doc links automatically.