JOSS Paper: Reduce line-spacing in code blocks #454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #454 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 20 20
Lines 1521 1521
Branches 419 419
=========================================
Hits 1521 1521 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The code-blocks have two line breaks in many places, in accordance with
black. However, the generous line-spacing is somewhat bothersome in a journal article format. I had intended there to be only one line break, but I think Alex's text editor may have auto-reformatted it upon upload. This PR reverts back to the single line-break format I had intended.Partially addresses (but does not close) #453.
@janosh: Could you please merge this too? Thanks!
Edit: How can we have the lint test skip the
paper.mdfile altogether?