Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed JobStore.from_dict_spec so that the original dict_spec is not modified #331

Merged
merged 2 commits into from
Jun 8, 2023

Conversation

davidwaroquiers
Copy link
Contributor

@davidwaroquiers davidwaroquiers commented Jun 2, 2023

Fixed JobStore.from_dict_spec so that the original dict_spec is not modified.
The spec is now copied so that if this is used programmatically, the type is not removed from the original spec_dict, which may be used afterwards, (e.g. stored in a database), or if there is some validation by a pydantic schema.

@utf For information, this is making the jobflow-remote fail in some of the config cases.

Summary

Include a summary of major changes in bullet points:

  • Modification of the internal _construct_store method so that the original dict_spec is not modified.

Additional dependencies introduced (if any)

None

TODO (if any)

None

Checklist

@codecov
Copy link

codecov bot commented Jun 2, 2023

Codecov Report

Merging #331 (7fe62c6) into main (7e62e93) will not change coverage.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #331   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           19        19           
  Lines         1429      1430    +1     
  Branches       361       361           
=========================================
+ Hits          1429      1430    +1     
Impacted Files Coverage Δ
src/jobflow/core/store.py 100.00% <100.00%> (ø)

@utf
Copy link
Member

utf commented Jun 8, 2023

Thanks!

@utf utf merged commit f9d74a2 into materialsproject:main Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants