Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New tutorial for generalized Makers #268

Merged
merged 3 commits into from
Mar 8, 2023
Merged

Conversation

jmmshn
Copy link
Contributor

@jmmshn jmmshn commented Feb 9, 2023

New tutorial for generalized Makers

  • Since I'm sorting out some code-agnostic stuff for the defect wfs I took some notes on how to actually implement these. @utf let me know if you agree with this as a "best practice".
  • Minor fix: isort bug in pre-commit

Link to notebook here:
https://github.com/jmmshn/jobflow/blob/main/tutorials/4-generalized-makers.ipynb

@codecov
Copy link

codecov bot commented Feb 10, 2023

Codecov Report

Merging #268 (b7e293d) into main (df9418c) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #268   +/-   ##
=======================================
  Coverage   99.85%   99.85%           
=======================================
  Files          19       19           
  Lines        1402     1402           
  Branches      351      351           
=======================================
  Hits         1400     1400           
  Misses          2        2           

@utf utf merged commit 32ae2a2 into materialsproject:main Mar 8, 2023
@utf
Copy link
Member

utf commented Mar 8, 2023

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants