Add JDFTx jobs.py to run JDFTx using atomate2/jobflow #349
Conversation
src/custodian/jdftx/jobs.py
Outdated
| stderr_file="std_err.txt", | ||
| ) -> None: | ||
| """ | ||
| This constructor is necessarily complex due to the need for |
There was a problem hiding this comment.
I think you can remove the note about the constructor being "complex", it doesn't seem to be complex. I believe this note is copy-pasted from another constructor that is complex
src/custodian/jdftx/jobs.py
Outdated
| ): | ||
| # use line buffering for stderr | ||
| return subprocess.run( | ||
| cmd.split(), |
src/custodian/jdftx/jobs.py
Outdated
| for cmd in self.jdftx_cmd: | ||
| if "jdftx" in cmd: | ||
| try: | ||
| os.system(f"killall {cmd}") |
There was a problem hiding this comment.
See implementation of terminate() in VASP job to avoid killing all JDFTx processes when possible
… conftest.py to store fixtures
Merge into main
|
Hi, |
|
@shyuep this looks ready from my side. I didn't check the tests in detail but rather just confirmed that they were there. Any issues with merging? |
|
@computron I don't have a problem with this, but I am puzzled why this is needed since there are no error handlers? |
|
@shyuep I wrote the atomate2 scripts using Custodian to run the processes to keep things consistent with the other codes. I'm working on the handlers and will add them once they're ready and I start running calculations using the workflows. |
|
MErged |
Summary
Hi,
This PR is to add jobs.py for JDFTx. We have a draft PR open on atomate2 to integrate JDFTx, but it seems that this script belongs here. Jobs.py was created using the CP2K template, with only the basic functionalities for now (just enough to run a job).
Todos
If this is work in progress, what else needs to be done?
Checklist
ruff.mypy.duecredit@due.dcitedecorators to reference relevant papers by DOI (example)Tip: Install
pre-commithooks to auto-check types and linting before every commit: