Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Gaussian job and handlers #328

Merged
merged 93 commits into from
Apr 24, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
93 commits
Select commit Hold shift + click to select a range
8308bdf
Add the start of the Gaussian handler
rashatwi Jun 1, 2021
7a23512
Add the start of the Gaussian job
rashatwi Jun 1, 2021
774d377
Add the start of the Gaussian custodian
rashatwi Jun 1, 2021
6a36c48
Add matplotlib to requirements
rashatwi Jun 4, 2021
3d380c4
Define better_scf_guess job
rashatwi Jun 4, 2021
db25860
Correct scf cycles error handling
rashatwi Jun 4, 2021
83755ba
Add an option to check convergence as a function of iterations
rashatwi Jun 4, 2021
81da0c0
Implement opt_steps error handling
rashatwi Jun 4, 2021
9d9c7e9
Implement solute_solvent_surface error handling
rashatwi Jun 4, 2021
f12d40e
Change integration grid
rashatwi Jun 9, 2021
7df3b8c
Update Gaussian integration grids
rashatwi Jun 9, 2021
7cd6617
Generate a better geom guess at a lower LOT
rashatwi Jun 9, 2021
b3e4440
Update better_guess job to be used with OPT and SCF job types
rashatwi Jun 9, 2021
9d69ef3
Add more error definitions
rashatwi Jun 14, 2021
3dd43bf
Add integral keyword to route_parameters
rashatwi Jun 14, 2021
19fb6d0
Remove empty spaces in route_params dict
rashatwi Jun 14, 2021
20ff9bc
Plot convergence only if data is available
rashatwi Jun 14, 2021
6e6214e
Restart opt calc if it appears to be converging
rashatwi Jun 14, 2021
d8c690a
Correct torsion error handler
rashatwi Jun 14, 2021
91d26c6
Cleanups
rashatwi Jun 14, 2021
e9d9638
Handle more errors
rashatwi Jun 14, 2021
59210cd
Cleanups
rashatwi Jun 14, 2021
47347c0
Correct how the integration grid is read
rashatwi Jun 15, 2021
f8396e5
Correct the conversion of convergence data to floats
rashatwi Jun 15, 2021
0826ba5
Correct the error of internal coords by performing opt using cart coo…
rashatwi Jun 16, 2021
ba6e3d7
Handle insufficient memory
rashatwi Jun 21, 2021
10c0be4
Fix bug in reading scf parameters
rashatwi Jul 17, 2021
1c33bfa
Add wall time handler
rashatwi Aug 18, 2021
a3ef501
Postprocess job
rashatwi Aug 18, 2021
9c0dcd1
Add the start of the Gaussian handler
rashatwi Jun 1, 2021
d778b99
Add the start of the Gaussian job
rashatwi Jun 1, 2021
9a6668a
Add the start of the Gaussian custodian
rashatwi Jun 1, 2021
054c17e
Define better_scf_guess job
rashatwi Jun 4, 2021
f842f87
Correct scf cycles error handling
rashatwi Jun 4, 2021
f3e89c0
Add an option to check convergence as a function of iterations
rashatwi Jun 4, 2021
3fd4820
Implement opt_steps error handling
rashatwi Jun 4, 2021
c3abf4d
Implement solute_solvent_surface error handling
rashatwi Jun 4, 2021
42ba6c4
Change integration grid
rashatwi Jun 9, 2021
47e9878
Update Gaussian integration grids
rashatwi Jun 9, 2021
0a8e8e7
Generate a better geom guess at a lower LOT
rashatwi Jun 9, 2021
9113286
Update better_guess job to be used with OPT and SCF job types
rashatwi Jun 9, 2021
3cd9d00
Add more error definitions
rashatwi Jun 14, 2021
5e01a40
Add integral keyword to route_parameters
rashatwi Jun 14, 2021
685adff
Remove empty spaces in route_params dict
rashatwi Jun 14, 2021
3f3e0f2
Plot convergence only if data is available
rashatwi Jun 14, 2021
0b81498
Restart opt calc if it appears to be converging
rashatwi Jun 14, 2021
cd7d0dc
Correct torsion error handler
rashatwi Jun 14, 2021
081ac1e
Cleanups
rashatwi Jun 14, 2021
f4539d9
Handle more errors
rashatwi Jun 14, 2021
178af9d
Cleanups
rashatwi Jun 14, 2021
c84f8d2
Correct how the integration grid is read
rashatwi Jun 15, 2021
672867a
Correct the conversion of convergence data to floats
rashatwi Jun 15, 2021
345a641
Correct the error of internal coords by performing opt using cart coo…
rashatwi Jun 16, 2021
2e1442f
Handle insufficient memory
rashatwi Jun 21, 2021
762e12f
Fix bug in reading scf parameters
rashatwi Jul 17, 2021
545dbf5
Add wall time handler
rashatwi Aug 18, 2021
f3bbc83
Postprocess job
rashatwi Aug 18, 2021
3a2bb31
Add gaussian dependencies
rashatwi Mar 13, 2024
b226eaa
Add docstrings and use directory as input arg
rashatwi Mar 21, 2024
cb9be17
Add terminate function to kill Gaussian job
rashatwi Mar 21, 2024
59b8816
Update Gaussian custodian version
rashatwi Mar 21, 2024
e6e40de
Use directory as input
rashatwi Mar 21, 2024
5174249
Bug fixes
rashatwi Mar 21, 2024
152eb5b
Linting
rashatwi Mar 21, 2024
65873a6
Linting
rashatwi Mar 21, 2024
37fa11f
Update Gaussian custodian version
rashatwi Mar 21, 2024
b59ad4d
Cleanups
rashatwi Mar 21, 2024
bdf7ec5
Remove old backup_gaussian_files function
rashatwi Mar 21, 2024
8c32c20
Add Gaussian handler docstrings
rashatwi Mar 21, 2024
7d4e096
Update docstrings
rashatwi Mar 21, 2024
39f6879
Update docstrings
rashatwi Mar 26, 2024
aedda5a
Fix typo in WallTimeErrorHandler
rashatwi Mar 26, 2024
2f08c8b
Add Gaussian tests
rashatwi Mar 26, 2024
104dbba
Add Gaussian test files
rashatwi Mar 26, 2024
081852e
Deactivate better guess after running test
rashatwi Mar 26, 2024
2da62df
Deactivate better guess after running test
rashatwi Mar 26, 2024
c660c03
Remove duplicate tearDown func
rashatwi Mar 26, 2024
a86bdd7
Correct class name
rashatwi Mar 26, 2024
282f5ee
Change rwf assertion statement
rashatwi Mar 26, 2024
b23ac85
Linting
rashatwi Mar 26, 2024
c6b31f9
Bug fix in matching error type
rashatwi Mar 26, 2024
07ddbcd
Replace actual Gaussian checkpoint files with mock ones
rashatwi Mar 28, 2024
5f3b204
Gzip Gaussian output files
rashatwi Mar 29, 2024
1f8e2a6
move matplotlib import into _monitor_convergence
janosh Mar 30, 2024
180990b
add type annotations to GaussianJob
janosh Mar 30, 2024
a8e6d95
Change better_guess func name in tests
rashatwi Mar 31, 2024
6ba9a40
Add type annotations to GaussianErrorHandler
rashatwi Apr 3, 2024
b64c436
`float` instead of `int | float` for mem
rashatwi Apr 3, 2024
c3dcf12
New Gaussian plugin (#325)
rashatwi Apr 3, 2024
851512c
ruff str format fixes, date assert refactor, rename test jobs
janosh Apr 3, 2024
f469ce1
Fix issue with gaussian .gz files
rashatwi Apr 23, 2024
62493af
Merge branch 'master' into pr/rashatwi/331
janosh Apr 24, 2024
67c79dd
Merge branch 'gaussian' into pr/rashatwi/331
janosh Apr 24, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .pre-commit-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ repos:
rev: v0.3.5
hooks:
- id: ruff
args: [--fix, --ignore, D]
args: [--fix, --ignore, D, --unsafe-fixes]
- id: ruff-format

- repo: https://github.com/pre-commit/pre-commit-hooks
Expand Down
10 changes: 10 additions & 0 deletions custodian/gaussian/__init__.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
"""
This package implements various Gaussian Jobs and Error Handlers.
"""
Comment on lines +1 to +3
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Condense the multi-line docstring into a single line to adhere to Python best practices.

- """
- This package implements various Gaussian Jobs and Error Handlers.
- """
+ """This package implements various Gaussian Jobs and Error Handlers."""

Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.

Suggested change
"""
This package implements various Gaussian Jobs and Error Handlers.
"""
"""This package implements various Gaussian Jobs and Error Handlers."""


__author__ = "Rasha Atwi"
__version__ = "0.1"
__maintainer__ = "Rasha Atwi"
__email__ = "rasha.atwi@stonybrook.edu"
__status__ = "Alpha"
__date__ = "5/13/21"
Loading
Loading