Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for directory for Q-Chem #318

Merged
merged 12 commits into from
Mar 11, 2024

Conversation

Andrew-S-Rosen
Copy link
Member

@Andrew-S-Rosen Andrew-S-Rosen commented Mar 8, 2024

This PR directly follows #317 (and addresses #316) by adding a directory option for the Q-Chem custodian routines, thereby making it thread-safe and also giving the user flexibility to run beyond the current working directory.

@codecov-commenter
Copy link

codecov-commenter commented Mar 8, 2024

Codecov Report

Attention: Patch coverage is 37.50000% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 62.57%. Comparing base (9b67478) to head (d7d99af).

Files Patch % Lines
custodian/qchem/jobs.py 36.36% 7 Missing ⚠️
custodian/qchem/handlers.py 40.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #318      +/-   ##
==========================================
- Coverage   62.67%   62.57%   -0.10%     
==========================================
  Files          35       35              
  Lines        3003     3009       +6     
==========================================
+ Hits         1882     1883       +1     
- Misses       1121     1126       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Andrew-S-Rosen Andrew-S-Rosen marked this pull request as draft March 8, 2024 22:35
@Andrew-S-Rosen Andrew-S-Rosen marked this pull request as ready for review March 9, 2024 06:35
@Andrew-S-Rosen Andrew-S-Rosen marked this pull request as draft March 9, 2024 06:51
@Andrew-S-Rosen Andrew-S-Rosen marked this pull request as ready for review March 11, 2024 17:11
@Andrew-S-Rosen
Copy link
Member Author

@janosh --- this should be ready to go. That said, just a head's up that there seems to be a slightly flakey windows test that is seemingly unrelated to this PR.

Sometimes it fails on Windows with Python 3.10 and sometimes with Python 3.12 and then other times not at all. I have only modified Q-Chem functions, so it doesn't seem to be associated with my changes in any obvious way.

@shyuep shyuep merged commit 30576c6 into materialsproject:master Mar 11, 2024
8 checks passed
@Andrew-S-Rosen Andrew-S-Rosen deleted the qchem branch March 11, 2024 18:49
@janosh janosh added enhancement qchem Q-Chem general-purpose electronic structure package handler Error handler labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement handler Error handler qchem Q-Chem general-purpose electronic structure package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants