Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix release CI #314

Merged
merged 10 commits into from
Feb 15, 2024
Merged

Fix release CI #314

merged 10 commits into from
Feb 15, 2024

Conversation

janosh
Copy link
Member

@janosh janosh commented Feb 15, 2024

help unblock materialsproject/atomate2#721

test.yml and release.yml workflows had different test setups. the latter install openbabel through miniconda, the former doesn't. as a result only a subset of tests are running on PRs but the full test suite when trying to make release. there was also lots of duplicaton which can avoided with GH reusable workflows after adding the workflow_call trigger to test.yml. makes test.yml the SSOT for how tests should be run

@janosh janosh added pkg Package ci Continuous integration labels Feb 15, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5148246) 62.54% compared to head (37b6177) 62.54%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #314   +/-   ##
=======================================
  Coverage   62.54%   62.54%           
=======================================
  Files          35       35           
  Lines        3006     3006           
=======================================
  Hits         1880     1880           
  Misses       1126     1126           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@janosh janosh merged commit 99227c2 into master Feb 15, 2024
2 of 3 checks passed
@janosh janosh deleted the fix-ci branch February 15, 2024 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continuous integration pkg Package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants