-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prep for next pymatgen
release
#690
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #690 +/- ##
=======================================
Coverage 76.25% 76.25%
=======================================
Files 87 87
Lines 7151 7151
Branches 1057 1057
=======================================
Hits 5453 5453
Misses 1374 1374
Partials 324 324
|
@mkhorton we have been installing atomate2 with [strict] for quite a while now as there were many issues because of the pydantic upgrade and incompatibilties with other MP codes. I think quite a few users have been doing this since then. Thus, the effect of this incompability should not be too big. |
@JaGeo i went the other extreme for the same reasons and have been installing |
@mkhorton thanks for raising this - unfortunately, the latest pymatgen had some bugs which meant it was not compatible with atomate2. Once a fixed version is released I can push a new atomate2 version. Currently, I'm the only one pushing releases but technically @janosh is able to do it also (as can anyone with push access to main). If pushing atomate2 versions is something @janosh would be interested in, then happy to chat about it over email. |
Also adding this for tracking: #719 |
Many
pymatgen
classes had inconsistently namedget/from_(str|string)
methods.get/from_string
was deprecated in favor ofget/from_str
6 months ago and removed last week in materialsproject/pymatgen#3561 which will be released this or next week.@utf this change will require a new
atomate2
version to be compatible with the upcomingpymatgen
.resulting
AttributeError
in currentatomate2
reported by @abhardwaj73 in materialsproject/pymatgen#3571 (comment). thanks!