Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Header dictionary pass through and BaseRester nesting fix #715

Merged
merged 7 commits into from
Dec 6, 2022

Conversation

munrojm
Copy link
Member

@munrojm munrojm commented Dec 6, 2022

  • Header dict pass through added to MPRester and BaseRester.
  • BaseRester not imports MaterialsRester for document ID checks instead of MPRester.

@munrojm munrojm added the release:patch Patch release label Dec 6, 2022
@codecov-commenter
Copy link

codecov-commenter commented Dec 6, 2022

Codecov Report

Base: 81.01% // Head: 80.94% // Decreases project coverage by -0.07% ⚠️

Coverage data is based on head (4d5fbf8) compared to base (49fc74a).
Patch coverage: 89.47% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #715      +/-   ##
==========================================
- Coverage   81.01%   80.94%   -0.08%     
==========================================
  Files          36       36              
  Lines        1754     1758       +4     
==========================================
+ Hits         1421     1423       +2     
- Misses        333      335       +2     
Impacted Files Coverage Δ
mp_api/client/core/client.py 89.18% <88.57%> (+0.08%) ⬆️
mp_api/client/mprester.py 58.64% <100.00%> (-0.43%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@munrojm munrojm merged commit 6bf1791 into main Dec 6, 2022
@munrojm munrojm deleted the enhancement/header_injection branch April 18, 2023 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:patch Patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants