Allow passing of MarketPlaceClient instance during app instantiation. #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csadorf
force-pushed
the
make-client-first-class-app-constructor-arg
branch
from
30322ba
to
fcae1c3
Compare
Instead of passing through client constructor arguments, we enable users to instantiate the client and then pass that directly. This is an improvement to the composition model as it does not require the replication of client constructor arguments within the app constructor function and also enables users to re-use an existing client instance.
csadorf
force-pushed
the
make-client-first-class-app-constructor-arg
branch
from
9f3a52d
to
9f081d4
Compare
singhpranjali
approved these changes
Aug 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of passing through client constructor arguments, we enable users
to instantiate the client and then pass that directly. This is an
improvement to the composition model as it does not require the
replication of client constructor arguments within the app constructor
function and also enables users to re-use an existing client instance.