Add message broker module

[yoavnash]

Closes #10

[csadorf]

Just a few suggestions. I think this is generally good enough for a starting point.

[yoavnash]

New changes:

• Model for response was added
• Renaming of queue name from to :<hash(application-id,application-secret)> (to increase security)

@pablo-de-andres for info.

[csadorf]

As discussed offline, please move the models into the https://github.com/materials-marketplace/standard-app-api code base. PR should be into the version-0.1.0 branch until that is merged.

I would suggest that you address my other comments prior to the move so that we can conclude the discussion before clustering it across repositories.

[csadorf]

@yoavnash How do you want to move forward? Should we make a (pre-?) release of https://github.com/materials-marketplace/standard-app-api and then update the PR here? Or do you want to temporarily depend on the git repository?

[yoavnash]

@yoavnash How do you want to move forward? Should we make a (pre-?) release of https://github.com/materials-marketplace/standard-app-api and then update the PR here? Or do you want to temporarily depend on the git repository?

I think it would be great to have a proper release of the standard-app-api package, as well as to publish it in PyPI. Then we can update this PR so that the models are imported from that repo.

[csadorf]

Blocked by: materials-marketplace/standard-app-api#10

[csadorf]

@yoavnash The marketplace-standard-app-api package version 0.1.0 is now published on PyPI: https://pypi.org/project/marketplace-standard-app-api/ and can be installed with pip install marketplace-standard-app-api.

[yoavnash]

Great :)

[yoavnash]

Some tests fail. @csadorf Do you think it has to do with the api package not supporting Python 3.8?

[csadorf]

Some tests fail. @csadorf Do you think it has to do with the api package not supporting Python 3.8?

Yes, it does. I will update the Python SDK requirements.

[csadorf]

@yoavnash Please rebase this branch on main and tests should pass.

[yoavnash]

Done. It's still failing though

[csadorf]

Done. It's still failing though

Yes, I think this is an unrelated issue either with the runners or the actions. Currently checking whether updating the actions in #16 resolves the issue.

[csadorf]

@yoavnash #16 has passed, would you mind rebasing once more on main? Also, I am not sure whether your previous rebase was clean since there are some changes that should not be there, e.g., https://github.com/materials-marketplace/python-sdk/pull/11/files#diff-b803fcb7f17ed9235f1e5cb1fcd2f5d3b2838429d4368ae4c57ce4436577f03f .

[yoavnash]

This time I merged instead of rebasing. The problem seems to be resolved. Thanks.
I think we can now proceed with merging this branch into main.

[csadorf]

I think the dependencies must be adjusted, otherwise good.

[csadorf]

Thanks a lot @yoavnash ! 👍