Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: Pre-commit hook installation fails #1

Closed
csadorf opened this issue Mar 28, 2022 · 4 comments
Closed

CI: Pre-commit hook installation fails #1

csadorf opened this issue Mar 28, 2022 · 4 comments
Assignees
@csadorf

Comments

@csadorf
Copy link
Collaborator

csadorf commented Mar 28, 2022

The CI pre-commit step fails, because of an installation issue.

See this comment for some context and explanation.

I anticipate that this problem is going to get fixed upstream within the next few days.
@csadorf csadorf self-assigned this Mar 28, 2022
@csadorf csadorf mentioned this issue Mar 28, 2022
Closed
@csadorf
Copy link
Collaborator Author

csadorf commented Mar 28, 2022

@pablo-de-andres I would recommend to just wait a few days to see if the issue resolves itself. In the meantime we can disable this particular step and/or active pre-commit.ci on this repo (once it is public). What do you think?

@pablo-de-andres
Copy link
Member

Makes sense, let's simply wait and monitor the status

@csadorf
Copy link
Collaborator Author

csadorf commented Mar 28, 2022

I'll disable the step in the meantime.

csadorf added a commit that referenced this issue Mar 28, 2022
@csadorf
CI: Temporarily disable pre-commit check.
445a410 
After root problem described in issue #1 is resolved.
This was referenced Mar 28, 2022
Merged
Merged
@pablo-de-andres pablo-de-andres mentioned this issue Apr 5, 2022
Merged
@csadorf
Copy link
Collaborator Author

csadorf commented Apr 5, 2022

Resolved with #7 .

@csadorf csadorf closed this as completed Apr 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@csadorf csadorf

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update ci.yml materials-marketplace/python-sdk
2 participants
@csadorf @pablo-de-andres