Add group selection #343
Merged
Add group selection #343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi thanks for this. I will take a look today. Looks good so far though. I requested the removal since we only had a few demos at that point. By now, we have a multitude and a demo would be appreciated. I will also look into the npx. Thanks again |
Domino987
approved these changes
Sep 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Credits to this PR fully go to @ollyrowe, I just took his unmerged PR and added here it since the original Material Table repo is stale and @mbrn is not responding. I just did some compatibility-related changes.
Relates to #503, #2314 and #503 of the original repo.
Description
Allows the user to select all the children of groups by clicking a checkbox of the group row, when
selectionandgroupingaretrue. This is something that has been mentioned several times and many people could use this (myself included, it's highly requested 😅 )Related PRs
No related PRs in other branches, only the aforementioned on the original repo.
Impacted Areas in Application
MTableBody and MTableGroupRow
Additional Notes
I did not add a demo since in the original PR @Domino987 requested to be removed. However, I've tested it by slightly altering a pre-existing demo and it works. If y'all want me to add an additional for this purpose, I'd be glad to.
Additionally, you might have noticed I changed
package.jsonto usingnpx. This is mainly because I was working on Windows and I couldn't commit any changes because of the"." is not recognized as an internal commandthrown when running Husky's pre-commit hook. Feel free to revert this but I think it might resolve some cross-env concerns 😄 .