-
Notifications
You must be signed in to change notification settings - Fork 909
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tabs have a shadow if its parent has --md-elevation-level #5137
Comments
I agree that the tab should include On a bigger note, these individual tab elevations do not make sense. We may want to consider deprecating tab elevation in favor of using As it's implemented, it's not possible to set a single shadow for the row of tabs, they incorrectly have their own shadows. |
Reference b/316459034 to clean this up |
Fixes #5137 PiperOrigin-RevId: 591131694
Fixes #5137 PiperOrigin-RevId: 591131694
Fixes #5137 PiperOrigin-RevId: 591131694
What is affected?
Component
Description
I was so confused why my tabs have dark borders except the 3 tabs surrounding the selecting tab:
Turned out it's due to a parent's
--md-elevation-level
(formd-elevation
effect).Reproduction
Lit Playground with both the problematic one and a workaround one:
Workaround
See above, setting
<md-tabs style="--md-elevation-level: 0">
fix it. I think the component itself should reset this.Is this a regression?
No or unsure. This never worked, or I haven't tried before.
Affected versions
1.0.1
Browser/OS/Node environment
Microsoft Edge Version 118.0.2088.69 (Official build) (64-bit)
The text was updated successfully, but these errors were encountered: