MDCList performance patch for listElements() #8195
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added element cache to MDCList listElements getter This fixes unacceptable O(n^2) complexity of operations calling listElements() repeatedly in a loop. See MDCListFoundation.getSelectedIndexFromDOM https://github.com/material-components/material-components-web/blob/9290bd3b0b919a022d6ff0cfd1c27bb66f7fd44b/packages/mdc-list/foundation.ts#L199 which becomes noticeably slow once a list has several hundred items (e.g. a selection of countries) and unusable for several thousand items, forcing clients to implement measures against long lists which might not be feasible for them.
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes performance of complexity O(n^2) operations which call listElements() within a loop. See MDCListFoundation.getSelectedIndexFromDOM
which becomes noticeably slow once a list has several hundred items (e.g. a selection of countries) and unusable for several thousand items, forcing clients to implement measures against long lists which might not be feasible for them.