Skip to content
This repository has been archived by the owner on Jan 13, 2025. It is now read-only.

feat(switch): Add density support for switch component. #5124

Merged
merged 5 commits into from
Sep 25, 2019

Conversation

joyzhong
Copy link
Contributor

@joyzhong joyzhong commented Sep 24, 2019

Fixes #5124 and #5104

  • Add mdc-switch-density, mdc-switch-ripple-size mixins
  • Rename $mdc-switch-tap-target-size => $mdc-switch-ripple-size, to be consistent with e.g. checkbox

BREAKING CHANGE: Renames switch variables $mdc-switch-tap-target-size => $mdc-switch-ripple-size, removes $mdc-switch-tap-target-initial-position and $mdc-switch-native-control-width.

@joyzhong joyzhong requested a review from abhiomkar September 24, 2019 18:26
@mdc-web-bot
Copy link
Collaborator

@mdc-web-bot
Copy link
Collaborator

🤖 Beep boop!

Screenshot test report 🚦

3 screenshots changed from develop on commit 1831218:

Details

@mdc-web-bot
Copy link
Collaborator

🤖 Beep boop!

Screenshot test report 🚦

3 screenshots changed from develop on commit b1fc610:

Details

Copy link
Collaborator

@abhiomkar abhiomkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@joyzhong joyzhong merged commit 2c793b4 into develop Sep 25, 2019
@joyzhong joyzhong deleted the feat/density_switch branch September 25, 2019 16:13
@jamesmfriedman jamesmfriedman mentioned this pull request Nov 4, 2019
93 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants