Skip to content
This repository has been archived by the owner on Jan 13, 2025. It is now read-only.

feat(slider): Implement continuous slider #487

Closed

Conversation

pgbross
Copy link
Contributor

@pgbross pgbross commented Apr 6, 2017

Prototype implementation of continuous slider (implementing #25)

I am working on a project that needs a continuous slider but notice the core team are not due to work on an mdc-slider component for some while. As I have created a component for my own use, I thought I would create a pull-request of the work I have so far in case it is useful enough to be incorporated earlier or if not, then it may at least be useful to the core team when they can start work on the slider component.

The continuous slider has been prototyped in Chrome, Firefox, IE, and iOS Safari (for touch awareness) and was heavily influenced by the concepts in the MDL v1 slider. It tries to follow examples and techniques from other mdc-components already in the material-components-web, but if you do wish to eventually incorporate it into the library it quite likely needs several iterations and or consultation/guidance on how to refine it and make it ready for production.

Let me know if it is useful and if you wish to take it further.

@codecov-io
Copy link

codecov-io commented Apr 6, 2017

Codecov Report

Merging #487 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #487      +/-   ##
=========================================
+ Coverage   99.19%   99.2%   +<.01%     
=========================================
  Files          40      43       +3     
  Lines        1980    2130     +150     
  Branches      250     260      +10     
=========================================
+ Hits         1964    2113     +149     
- Misses         16      17       +1
Impacted Files Coverage Δ
packages/mdc-slider/continuous/foundation.js 100% <100%> (ø)
packages/mdc-slider/continuous/constants.js 100% <100%> (ø)
packages/mdc-slider/continuous/index.js 100% <100%> (ø)
packages/mdc-ripple/foundation.js 99.48% <0%> (-0.52%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 12bd03e...64268d8. Read the comment docs.

@pgbross pgbross force-pushed the feat/implement-slider branch 2 times, most recently from 83349e0 to 0a19b31 Compare April 10, 2017 09:44
@pgbross pgbross force-pushed the feat/implement-slider branch from 4a0eec3 to 64268d8 Compare April 10, 2017 16:47
@traviskaufman
Copy link
Contributor

Hey @pgbross,

Thanks for taking the time to share your code with us and do all of this work. While we'd be more than happy to assist you in taking this on, I feel that the best way to do this would be by closing this PR and tracking development on the Github Issue itself. This way, we can guide you through the correct eng process for developing new components, provide you with some visual prototypes (which we have worked on for sliders already), and ensure that the DOM structure and API is what we expect without having to go through numerous rounds of PR reviews. Thus, I'm going to close this for now.

If you'd like to take a pass at sliders, please comment on the issue and we'll get the ball rolling on helping you with an initial visual prototype / eng outline. And thanks again for your willingness to contribute and make our codebase that much better!

@traviskaufman traviskaufman mentioned this pull request Apr 10, 2017
2 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants