-
Notifications
You must be signed in to change notification settings - Fork 2.1k
feat(auto-init): initialize components once with multiple mdc.autoInit() calls #4691
Conversation
All 645 screenshot tests passed for commit f634e82 vs. |
All 645 screenshot tests passed for commit 57bbcef vs. |
All 687 screenshot tests passed for commit 989f298 vs. |
…erial-components/material-components-web into feat/auto-init/add-auto-init-trackng
ready for rereview |
All 687 screenshot tests passed for commit 165194e vs. |
All 687 screenshot tests passed for commit f20eb17 vs. |
packages/mdc-auto-init/constants.ts
Outdated
export const strings = { | ||
AUTO_INIT_ATTR: 'data-mdc-auto-init', | ||
AUTO_INIT_STATE_ATTR: 'data-mdc-auto-init-state', | ||
INTIALIZED_STATE: 'initialized', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo* INITIALIZED_STATE
All 687 screenshot tests passed for commit 22a86ae vs. |
The
Looking for other solutions. Failure seen in https://travis-ci.com/material-components/material-components-web/jobs/200896441 |
All 687 screenshot tests passed for commit 364139d vs. |
…erial-components/material-components-web into feat/auto-init/add-auto-init-trackng
Codecov Report
@@ Coverage Diff @@
## master #4691 +/- ##
=========================================
Coverage ? 98.97%
=========================================
Files ? 129
Lines ? 6331
Branches ? 821
=========================================
Hits ? 6266
Misses ? 64
Partials ? 1
Continue to review full report at Codecov.
|
All 687 screenshot tests passed for commit 525eb29 vs. |
fixes #4495