This repository has been archived by the owner on Jan 13, 2025. It is now read-only.
fix(text-field): Fix for input alignment in textfield with trailing icon #4478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kfranqueiro
reviewed
Mar 12, 2019
kfranqueiro
approved these changes
Mar 12, 2019
|
🤖 Beep boop! Screenshot test report 🚦15 screenshots changed from |
adrianschmidt
pushed a commit
to Lundalogik/material-components-web
that referenced
this pull request
Mar 29, 2019
…con (material-components#4478) (cherry picked from commit b9c5fc6)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made changes to private mixin of
text-field/icon:mdc-text-field-icon-horizontal-position_by adding a new argument to send default text field input padding for trailing icon variant.In previous implementation it assumes the leading input padding and the icon position always equals, but it is not the case in filled variant since the icon position is 4px lesser (
12px) in filled variant compared to outlined variant (16px).Before
After
Fixes #4416