Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(text-field): Adjust the baseline of text field's helper text to match spec #3069

Merged
merged 20 commits into from
Aug 1, 2018
Merged

fix(text-field): Adjust the baseline of text field's helper text to match spec #3069

merged 20 commits into from
Aug 1, 2018

Commits on Jul 13, 2018

  1. fix(text-field): Fixed the baseline of helper text

    @abhiomkar
    abhiomkar committed Jul 13, 2018
    Configuration menu
    Copy the full SHA
    f02f054 View commit details
    Browse the repository at this point in the history

  2. fix(text-field): Moved line-height to typography baseline mixin

    @abhiomkar
    abhiomkar committed Jul 13, 2018
    Configuration menu
    Copy the full SHA
    37ecac9 View commit details
    Browse the repository at this point in the history

  3. fix(text-field): Removed margin-bottom from helper text

    @abhiomkar
    abhiomkar committed Jul 13, 2018
    Configuration menu
    Copy the full SHA
    3b5bbad View commit details
    Browse the repository at this point in the history

Commits on Jul 16, 2018

  1. feat(typography): Updated baseline mixin to include styles for ::after

    @abhiomkar
    abhiomkar committed Jul 16, 2018
    Configuration menu
    Copy the full SHA
    c06dd4e View commit details
    Browse the repository at this point in the history

  2. feat(typography): Added text baseline mixin with a demo

    @abhiomkar
    abhiomkar committed Jul 16, 2018
    Configuration menu
    Copy the full SHA
    93a22b2 View commit details
    Browse the repository at this point in the history

  3. feat(typography): Fixed stylelint errors

    @abhiomkar
    abhiomkar committed Jul 16, 2018
    Configuration menu
    Copy the full SHA
    6293f53 View commit details
    Browse the repository at this point in the history

  4. fix(text-field): Merged typography branch here

    @abhiomkar
    abhiomkar committed Jul 16, 2018
    Configuration menu
    Copy the full SHA
    07287ec View commit details
    Browse the repository at this point in the history

Commits on Jul 23, 2018

  1. feat(typography): Divided baseline mixin into two seperate mixins

    @abhiomkar
    abhiomkar committed Jul 23, 2018
    Configuration menu
    Copy the full SHA
    4930296 View commit details
    Browse the repository at this point in the history

Commits on Jul 24, 2018

  1. Merge branch 'typography_text_baseline' into textfield_helper_text_ba… 

    …seline_issue2783
    @abhiomkar
    abhiomkar committed Jul 24, 2018
    Configuration menu
    Copy the full SHA
    54ebe4b View commit details
    Browse the repository at this point in the history

  2. fix(text-field): Use updated baseline mixin

    @abhiomkar
    abhiomkar committed Jul 24, 2018
    Configuration menu
    Copy the full SHA
    6b3557e View commit details
    Browse the repository at this point in the history

Commits on Jul 25, 2018

  1. Merge remote-tracking branch 'origin/master' into textfield_helper_te… 

    …xt_baseline_issue2783
    @abhiomkar
    abhiomkar committed Jul 25, 2018
    Configuration menu
    Copy the full SHA
    3578a2b View commit details
    Browse the repository at this point in the history

  2. fix(text-field): Removed white-space chars from helper text

    @abhiomkar
    abhiomkar committed Jul 25, 2018
    Configuration menu
    Copy the full SHA
    b132601 View commit details
    Browse the repository at this point in the history

Commits on Jul 30, 2018

  1. fix(text-field): Used flexbox on baseline line struts to avoid extra … 

    …white-space
    @abhiomkar
    abhiomkar committed Jul 30, 2018
    Configuration menu
    Copy the full SHA
    b246aee View commit details
    Browse the repository at this point in the history

  2. fix(text-field): minor change - removed extra white-space from demo

    @abhiomkar
    abhiomkar committed Jul 30, 2018
    Configuration menu
    Copy the full SHA
    f31641e View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'origin/master' into textfield_helper_te… 

    …xt_baseline_issue2783
    @abhiomkar
    abhiomkar committed Jul 30, 2018
    Configuration menu
    Copy the full SHA
    16a904f View commit details
    Browse the repository at this point in the history

Commits on Aug 1, 2018

  1. Merge remote-tracking branch 'origin/master' into textfield_helper_te… 

    …xt_baseline_issue2783
    @abhiomkar
    abhiomkar committed Aug 1, 2018
    Configuration menu
    Copy the full SHA
    a3a1543 View commit details
    Browse the repository at this point in the history

  2. fix(text-field): Reverted helper text README

    @abhiomkar
    abhiomkar committed Aug 1, 2018
    Configuration menu
    Copy the full SHA
    139fbc8 View commit details
    Browse the repository at this point in the history

  3. fix(text-field): Removed unused parameter in typography private mixin

    @abhiomkar
    abhiomkar committed Aug 1, 2018
    Configuration menu
    Copy the full SHA
    2bfa646 View commit details
    Browse the repository at this point in the history

  4. fix(text-field): Use visibility instead of display when show/hide hel… 

    …per text in demo
    @abhiomkar
    abhiomkar committed Aug 1, 2018
    Configuration menu
    Copy the full SHA
    de69151 View commit details
    Browse the repository at this point in the history

  5. fix(text-field): Updated other helper texts to use visibility in demo

    @abhiomkar
    abhiomkar committed Aug 1, 2018
    Configuration menu
    Copy the full SHA
    3d304b4 View commit details
    Browse the repository at this point in the history