This repository has been archived by the owner on Jan 13, 2025. It is now read-only.
docs: update main readme with React and Web Components links #2727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickrodee
suggested changes
May 10, 2018
README.md
Outdated
| @@ -18,6 +18,8 @@ Material Components for the web is the successor to [Material Design Lite](https | |||
| - [Blox Material](https://blox.src.zone/material): Angular Integration Library. | |||
| - [Vue MDC Adapter](https://github.com/stasson/vue-mdc-adapter): MDC Web Integration for Vue.js (using [foundation/adapters](./docs/integrating-into-frameworks.md#the-advanced-approach-using-foundations-and-adapters).) | |||
| - [Material Components Vue](https://github.com/matsp/material-components-vue): MDC Web Integration for Vue.js (using [vanilla components](./docs/integrating-into-frameworks.md#the-simple-approach-wrapping-mdc-web-vanilla-components)) | |||
| - [Material Components React](https://github.com/material-components/material-components-web-react): MDC Web Integration for React.js (using [foundation/adapters](./docs/integrating-into-frameworks.md#the-advanced-approach-using-foundations-and-adapters)) | |||
| - [Material Web Components](https://github.com/material-components/material-components-web-components): MDC Web Integration for Web Components (using [vanilla components](./docs/integrating-into-frameworks.md#the-simple-approach-wrapping-mdc-web-vanilla-components)) | |||
There was a problem hiding this comment.
What's the value in the self-referential link?
There was a problem hiding this comment.
are you referring to the Material Web Components link? That is the polymer repo
There was a problem hiding this comment.
MY BAD!!!!! I completely missed that. The name is so similar.
Codecov Report
@@ Coverage Diff @@
## master #2727 +/- ##
=======================================
Coverage 98.48% 98.48%
=======================================
Files 98 98
Lines 4230 4230
Branches 537 537
=======================================
Hits 4166 4166
Misses 64 64Continue to review full report at Codecov.
|
kfranqueiro
suggested changes
May 11, 2018
README.md
Outdated
| @@ -18,6 +18,8 @@ Material Components for the web is the successor to [Material Design Lite](https | |||
| - [Blox Material](https://blox.src.zone/material): Angular Integration Library. | |||
| - [Vue MDC Adapter](https://github.com/stasson/vue-mdc-adapter): MDC Web Integration for Vue.js (using [foundation/adapters](./docs/integrating-into-frameworks.md#the-advanced-approach-using-foundations-and-adapters).) | |||
| - [Material Components Vue](https://github.com/matsp/material-components-vue): MDC Web Integration for Vue.js (using [vanilla components](./docs/integrating-into-frameworks.md#the-simple-approach-wrapping-mdc-web-vanilla-components)) | |||
| - [Material Components React](https://github.com/material-components/material-components-web-react): MDC Web Integration for React.js (using [foundation/adapters](./docs/integrating-into-frameworks.md#the-advanced-approach-using-foundations-and-adapters)) | |||
There was a problem hiding this comment.
Should we consider putting these at the top given that they're first-party whereas the others are third-party? Maybe even have a separate sub-bullet for third-party integrations?
e.g.
- Seamless integration with other JS frameworks and libraries
- Material Components for React (note the presence of "for", too)
- Material Web Components
- Additional third-party integrations
- (rest of list here)
kfranqueiro
suggested changes
May 14, 2018
README.md
Outdated
| - [Blox Material](https://blox.src.zone/material): Angular Integration Library. | ||
| - [Vue MDC Adapter](https://github.com/stasson/vue-mdc-adapter): MDC Web Integration for Vue.js (using [foundation/adapters](./docs/integrating-into-frameworks.md#the-advanced-approach-using-foundations-and-adapters).) | ||
| - [Material Components Vue](https://github.com/matsp/material-components-vue): MDC Web Integration for Vue.js (using [vanilla components](./docs/integrating-into-frameworks.md#the-simple-approach-wrapping-mdc-web-vanilla-components)) | ||
| - [Material Components for React](https://github.com/material-components/material-components-web-react): MDC Web Integration for React.js (using [foundation/adapters](./docs/integrating-into-frameworks.md#the-advanced-approach-using-foundations-and-adapters)) |
There was a problem hiding this comment.
- Drop ".js" from React? (It's referred to simply as React on their own site)
- lowercase i in integration
- foundation -> foundations
README.md
Outdated
| - [Vue MDC Adapter](https://github.com/stasson/vue-mdc-adapter): MDC Web Integration for Vue.js (using [foundation/adapters](./docs/integrating-into-frameworks.md#the-advanced-approach-using-foundations-and-adapters).) | ||
| - [Material Components Vue](https://github.com/matsp/material-components-vue): MDC Web Integration for Vue.js (using [vanilla components](./docs/integrating-into-frameworks.md#the-simple-approach-wrapping-mdc-web-vanilla-components)) | ||
| - [Material Components for React](https://github.com/material-components/material-components-web-react): MDC Web Integration for React.js (using [foundation/adapters](./docs/integrating-into-frameworks.md#the-advanced-approach-using-foundations-and-adapters)) | ||
| - [Material Web Components](https://github.com/material-components/material-components-web-components): MDC Web Integration for Web Components (using [vanilla components](./docs/integrating-into-frameworks.md#the-simple-approach-wrapping-mdc-web-vanilla-components)) |
There was a problem hiding this comment.
lowercase i in integration
kfranqueiro
approved these changes
May 14, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes material-components/material-components-web-react#26