Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(chips): Replace leading icon with checkmark in selected filter chips #2320

Merged
merged 47 commits into from
Mar 13, 2018
Merged

feat(chips): Replace leading icon with checkmark in selected filter chips #2320

merged 47 commits into from
Mar 13, 2018

Commits on Feb 21, 2018

  1. feat(chips): Add multi-select for filter chips

    @bonniezhou
    bonniezhou committed Feb 21, 2018
    Configuration menu
    Copy the full SHA
    51a3f28 View commit details
    Browse the repository at this point in the history

  2. Fix test

    @bonniezhou
    bonniezhou committed Feb 21, 2018
    Configuration menu
    Copy the full SHA
    ee7a9b1 View commit details
    Browse the repository at this point in the history

Commits on Feb 22, 2018

  1. Hide/unhide leading and filter icons

    @bonniezhou
    bonniezhou committed Feb 22, 2018
    Configuration menu
    Copy the full SHA
    b3d1c45 View commit details
    Browse the repository at this point in the history

  2. Animations

    @bonniezhou
    bonniezhou committed Feb 22, 2018
    Configuration menu
    Copy the full SHA
    fd5a6e6 View commit details
    Browse the repository at this point in the history

Commits on Feb 23, 2018

  1. Checkmark filter icon animations working beautifully

    @bonniezhou
    bonniezhou committed Feb 23, 2018
    Configuration menu
    Copy the full SHA
    7c5e552 View commit details
    Browse the repository at this point in the history

  2. svg checkmark WIP

    @bonniezhou
    bonniezhou committed Feb 23, 2018
    Configuration menu
    Copy the full SHA
    4ad4f01 View commit details
    Browse the repository at this point in the history

Commits on Feb 27, 2018

  1. Get checkmark working with no leading icon

    @bonniezhou
    bonniezhou committed Feb 27, 2018
    Configuration menu
    Copy the full SHA
    830c49c View commit details
    Browse the repository at this point in the history

  2. Get checkmark to replace leading icon

    @bonniezhou
    bonniezhou committed Feb 27, 2018
    Configuration menu
    Copy the full SHA
    da9c19a View commit details
    Browse the repository at this point in the history

  3. Reorganize css

    @bonniezhou
    bonniezhou committed Feb 27, 2018
    Configuration menu
    Copy the full SHA
    5803bbc View commit details
    Browse the repository at this point in the history

  4. Got everything working omg

    @bonniezhou
    bonniezhou committed Feb 27, 2018
    Configuration menu
    Copy the full SHA
    3d29476 View commit details
    Browse the repository at this point in the history

  5. Clean it up

    @bonniezhou
    bonniezhou committed Feb 27, 2018
    Configuration menu
    Copy the full SHA
    13cda04 View commit details
    Browse the repository at this point in the history

Commits on Feb 28, 2018

  1. feat(chips): Replace leading icon with checkmark in selected filter c… 

    …hips
    @bonniezhou
    bonniezhou committed Feb 28, 2018
    Configuration menu
    Copy the full SHA
    3bbc49f View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into feat/chips/filter-checkmark

    @bonniezhou
    bonniezhou authored Feb 28, 2018
    Configuration menu
    Copy the full SHA
    32882eb View commit details
    Browse the repository at this point in the history

  3. Clean up and add readme

    @bonniezhou
    bonniezhou committed Feb 28, 2018
    Configuration menu
    Copy the full SHA
    0590d82 View commit details
    Browse the repository at this point in the history

  4. fix tests WIP

    @bonniezhou
    bonniezhou committed Feb 28, 2018
    Configuration menu
    Copy the full SHA
    6d72ce7 View commit details
    Browse the repository at this point in the history

Commits on Mar 1, 2018

  1. update readme

    @bonniezhou
    bonniezhou committed Mar 1, 2018
    Configuration menu
    Copy the full SHA
    08a3d72 View commit details
    Browse the repository at this point in the history

Commits on Mar 2, 2018

  1. Merge branch 'master' into feat/chips/filter-checkmark

    @bonniezhou
    bonniezhou authored Mar 2, 2018
    Configuration menu
    Copy the full SHA
    e474cd2 View commit details
    Browse the repository at this point in the history

  2. Adjust merge with selected color

    @bonniezhou
    bonniezhou committed Mar 2, 2018
    Configuration menu
    Copy the full SHA
    c7fac24 View commit details
    Browse the repository at this point in the history

  3. Add tests

    @bonniezhou
    bonniezhou committed Mar 2, 2018
    Configuration menu
    Copy the full SHA
    fc50fd3 View commit details
    Browse the repository at this point in the history

  4. Add tests for coverage

    @bonniezhou
    bonniezhou committed Mar 2, 2018
    Configuration menu
    Copy the full SHA
    cb805d8 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'master' into feat/chips/filter-checkmark

    @bonniezhou
    bonniezhou authored Mar 2, 2018
    Configuration menu
    Copy the full SHA
    34c806f View commit details
    Browse the repository at this point in the history

Commits on Mar 5, 2018

  1. change isOk to isTrue

    @bonniezhou
    bonniezhou committed Mar 5, 2018
    Configuration menu
    Copy the full SHA
    65055a2 View commit details
    Browse the repository at this point in the history

  2. getLeadingIcon

    @bonniezhou
    bonniezhou committed Mar 5, 2018
    Configuration menu
    Copy the full SHA
    66a9cc9 View commit details
    Browse the repository at this point in the history

Commits on Mar 6, 2018

  1. Nesting and readme update

    @bonniezhou
    bonniezhou committed Mar 6, 2018
    Configuration menu
    Copy the full SHA
    2be956e View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into feat/chips/filter-checkmark

    @bonniezhou
    bonniezhou authored Mar 6, 2018
    Configuration menu
    Copy the full SHA
    a6027c2 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into feat/chips/filter-checkmark

    @bonniezhou
    bonniezhou authored Mar 6, 2018
    Configuration menu
    Copy the full SHA
    485d880 View commit details
    Browse the repository at this point in the history

Commits on Mar 7, 2018

  1. Add periods

    @bonniezhou
    bonniezhou committed Mar 7, 2018
    Configuration menu
    Copy the full SHA
    2d7c003 View commit details
    Browse the repository at this point in the history

  2. Reuse event handler for toplevel chip for leading icon and checkmark … 

    …transition end event
    @bonniezhou
    bonniezhou committed Mar 7, 2018
    Configuration menu
    Copy the full SHA
    f33da26 View commit details
    Browse the repository at this point in the history

  3. Rename registerInteractionHandler to registerEventHandler

    @bonniezhou
    bonniezhou committed Mar 7, 2018
    Configuration menu
    Copy the full SHA
    581a41f View commit details
    Browse the repository at this point in the history

  4. Store leading icon in instance properties

    @bonniezhou
    bonniezhou committed Mar 7, 2018
    Configuration menu
    Copy the full SHA
    cb19f1a View commit details
    Browse the repository at this point in the history

  5. add animation and checkmark to package.json

    @bonniezhou
    bonniezhou committed Mar 7, 2018
    Configuration menu
    Copy the full SHA
    d2c5fad View commit details
    Browse the repository at this point in the history

  6. Nits

    @bonniezhou
    bonniezhou committed Mar 7, 2018
    Configuration menu
    Copy the full SHA
    965d79e View commit details
    Browse the repository at this point in the history

  7. Merge branch 'master' into feat/chips/filter-checkmark

    @bonniezhou
    bonniezhou authored Mar 7, 2018
    Configuration menu
    Copy the full SHA
    6e447a5 View commit details
    Browse the repository at this point in the history

Commits on Mar 8, 2018

  1. Remove extra vertical-align

    @bonniezhou
    bonniezhou committed Mar 8, 2018
    Configuration menu
    Copy the full SHA
    7beb1fd View commit details
    Browse the repository at this point in the history

  2. Nits

    @bonniezhou
    bonniezhou committed Mar 8, 2018
    Configuration menu
    Copy the full SHA
    7d04e5c View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into feat/chips/filter-checkmark

    @bonniezhou
    bonniezhou authored Mar 8, 2018
    Configuration menu
    Copy the full SHA
    8854e40 View commit details
    Browse the repository at this point in the history

Commits on Mar 9, 2018

  1. proper Closure for eventTargetHasClass

    @bonniezhou
    bonniezhou committed Mar 9, 2018
    Configuration menu
    Copy the full SHA
    a288a0e View commit details
    Browse the repository at this point in the history

  2. Wrap div around svg because IE

    @bonniezhou
    bonniezhou committed Mar 9, 2018
    Configuration menu
    Copy the full SHA
    c90213b View commit details
    Browse the repository at this point in the history

  3. Update readme

    @bonniezhou
    bonniezhou committed Mar 9, 2018
    Configuration menu
    Copy the full SHA
    bf868ef View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' into feat/chips/filter-checkmark

    @bonniezhou
    bonniezhou authored Mar 9, 2018
    Configuration menu
    Copy the full SHA
    ff045d7 View commit details
    Browse the repository at this point in the history

  5. Force closure to accept evt.target

    @bonniezhou
    bonniezhou committed Mar 9, 2018
    Configuration menu
    Copy the full SHA
    75884c5 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'master' into feat/chips/filter-checkmark

    @bonniezhou
    bonniezhou authored Mar 9, 2018
    Configuration menu
    Copy the full SHA
    a4d7b24 View commit details
    Browse the repository at this point in the history

  7. Remove all classes from svg for IE

    @bonniezhou
    bonniezhou committed Mar 9, 2018
    Configuration menu
    Copy the full SHA
    1e3d496 View commit details
    Browse the repository at this point in the history

  8. Merge branch 'master' into feat/chips/filter-checkmark

    @bonniezhou
    bonniezhou authored Mar 9, 2018
    Configuration menu
    Copy the full SHA
    44a4982 View commit details
    Browse the repository at this point in the history

Commits on Mar 13, 2018

  1. Revert "Remove all classes from svg for IE" 

    This reverts commit 1e3d496.
    @bonniezhou
    bonniezhou committed Mar 13, 2018
    Configuration menu
    Copy the full SHA
    dff38f8 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into feat/chips/filter-checkmark

    @bonniezhou
    bonniezhou authored Mar 13, 2018
    Configuration menu
    Copy the full SHA
    dfa6d26 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into feat/chips/filter-checkmark

    @bonniezhou
    bonniezhou authored Mar 13, 2018
    Configuration menu
    Copy the full SHA
    1a84c1c View commit details
    Browse the repository at this point in the history