This repository has been archived by the owner on Jan 13, 2025. It is now read-only.
chore(tabs): move indicator sass into custom mixins #1965
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lynnmercier
suggested changes
Jan 16, 2018
| } | ||
|
|
||
| .custom-toolbar-indicator .custom-indicator-toolbar-tab-bar { | ||
| @include mdc-tab-bar-indicator-ink-color(secondary); |
There was a problem hiding this comment.
this example seems to do the same thing as above...do we really need it?
There was a problem hiding this comment.
Its similar, but a different color (primary vs secondary). Also we need it to target the toolbar specifier. If we don't have that we cannot override the color. If we remove the toolbar scss, we can probably get around this.
There was a problem hiding this comment.
I'll update this after I remove toolbar specific sass
|
|
||
| @mixin mdc-tab-bar-indicator-ink-color($color) { | ||
| .mdc-tab-bar__indicator, | ||
| &:not(.mdc-tab-bar-upgraded) .mdc-tab::after { |
There was a problem hiding this comment.
I worry about & used within a comma separated selector.
Can you double check this &:not(.mdc-tab-bar-upgraded) .mdc-tab::after works with the css only version of tabs on our demo page?
There was a problem hiding this comment.
It looks the same as seen on https://material-components-web.appspot.com/tabs.html. Although locally and on master, the CSS-only indicator is slightly thinner. I looked into why, and the calculated top value has changed from 43px to 46px. I didn't track down when the changed occurred, but I will open a separate issue for this.
Other than that, it is behaving the same.
| @@ -47,6 +48,7 @@ | |||
|
|
|||
| // postcss-bem-linter: ignore | |||
| .mdc-toolbar & { | |||
There was a problem hiding this comment.
What does all this code do...the stuff under .mdc-toolbar &....which I assume translates to .mdc-toolbar .mdc-tab-bar
Why do we need so much code to get a tab bar to work within a toolbar? Maybe we don't need this now that we're customizing color through mixins?
There was a problem hiding this comment.
We could remove this and then have mixins to customize toolbar specific tab-bars. I like that idea. This will be a breaking change though, so I'll check the rest of the repo.
| @@ -78,34 +78,3 @@ | |||
| .mdc-tab-bar--icons-with-text { | |||
| height: 72px; | |||
| } | |||
|
|
|||
| .mdc-tab-bar--indicator-primary, | |||
There was a problem hiding this comment.
removing these --primary and --accent is a breaking change, so remember to add that to the commit
added 8 commits
January 16, 2018 12:08
…mos to reflect this. BREAKING CHANGE: removal of .mdc-toolbar selector forces clients to customize tab-bars within toolbars that require a different ink color.
…mponents/material-components-web into chore/tabs/color-sass-mixins
…dated demos to reflect this." This reverts commit d98e5d8.
Codecov Report
@@ Coverage Diff @@
## master #1965 +/- ##
=======================================
Coverage 99.43% 99.43%
=======================================
Files 84 84
Lines 3717 3717
Branches 485 485
=======================================
Hits 3696 3696
Misses 21 21Continue to review full report at Codecov.
|
lynnmercier
suggested changes
Jan 17, 2018
| @@ -2,7 +2,7 @@ | |||
|
|
|||
| @mixin mdc-tab-bar-indicator-ink-color($color) { | |||
| .mdc-tab-bar__indicator, | |||
| &:not(.mdc-tab-bar-upgraded) .mdc-tab::after { | |||
| &.mdc-tab-bar:not(.mdc-tab-bar-upgraded) .mdc-tab::after { | |||
There was a problem hiding this comment.
HMmmmmmmmmm...this is tricky
Remind me, why do we use .mdc-tab::after and not .mdc-tab-bar__indicator for the CSS only version of tabs?
There was a problem hiding this comment.
Going to look into removing the .mdc-tab::after element in favor of .mdc-tab-bar__indicator. Will open pre-pr if possible
Dramloc
added a commit
to Dramloc/preact-material-components
that referenced
this pull request
May 16, 2018
Remove `indicator-accent` from `Tabs` as it is no longer used (material-components/material-components-web#1965)
prateekbh
pushed a commit
to prateekbh/preact-material-components
that referenced
this pull request
May 28, 2018
* 🔥 Remove `indicator-accent` from `Tabs` component Remove `indicator-accent` from `Tabs` as it is no longer used (material-components/material-components-web#1965) * Add TabBarScrollerTabs component - `TabBarScrollerTabs` should be used within `TabBarScroller` instead of `Tabs`. - Component name is inspired by class name used by @material/mdc-tab: '.mdc-tab-bar-scroller__scroll-frame__tabs' - `scroller` property is no longer needed on `Tabs` and allows a simpler implementation - `activeTabIndex` can be used on `Tabs` and `TabBarScroller` to select active tab index * Fix prettier formatting * Uptable tabs golden screenshot
prateekbh
added a commit
to prateekbh/preact-material-components
that referenced
this pull request
Jul 3, 2018
* Release (#793) * Doc changes (#742) * fixing version number * fixing env target * changing docs language * new deps (#741) * new deps * Sync with Prettier * Sync with Prettier * fixing docs pics * fixing pics (#743) * fixing pics * Update package.json * fixing pics * Update docs (#785) * fixing version number * fixing env target * changing docs language * new deps (#741) * new deps * Sync with Prettier * Sync with Prettier * fixing docs pics * fixing pics (#743) * fixing pics * Update package.json * fixing pics * upgrading to 34 (#744) * upgrading to 34 * Sync with Prettier * text field value support * Sync with Prettier * Sync with Prettier * fixing tests * Release docs (#790) * fixing version number * fixing env target * changing docs language * new deps (#741) * new deps * Sync with Prettier * Sync with Prettier * fixing docs pics * fixing pics (#743) * fixing pics * Update package.json * fixing pics * upgrading to 34 (#744) * upgrading to 34 * Sync with Prettier * text field value support * Sync with Prettier * Sync with Prettier * fixing tests * close greenkeeper (#786) * updating to mdc 35 (#787) * updating to mdc 35 * Sync with Prettier * fixing errors and adding typography * test fix * fixing new images * Sync with Prettier * adding routes in pre-render * bug fix * test fixes * Prettierfix (#797) - optional prettier fix - hoek fix * v1.4.5 - Fixed typings for Typography. (#798) * Fix Tabs within TabBarScroller initialized multiple times (#796) * 🔥 Remove `indicator-accent` from `Tabs` component Remove `indicator-accent` from `Tabs` as it is no longer used (material-components/material-components-web#1965) * Add TabBarScrollerTabs component - `TabBarScrollerTabs` should be used within `TabBarScroller` instead of `Tabs`. - Component name is inspired by class name used by @material/mdc-tab: '.mdc-tab-bar-scroller__scroll-frame__tabs' - `scroller` property is no longer needed on `Tabs` and allows a simpler implementation - `activeTabIndex` can be used on `Tabs` and `TabBarScroller` to select active tab index * Fix prettier formatting * Uptable tabs golden screenshot * typo in import (#799) * chore(package): update webpack-cli to version 3.0.0 (#800) * Update @material/rtl to the latest version 🚀 (#801) * fix(package): update @material/rtl to version 0.36.0 * Sync with Prettier * Don't bundle a copy of Preact into dist (#826) * Update index.js * Updating deps (#827) * Doc changes (#742) * fixing version number * fixing env target * changing docs language * new deps (#741) * new deps * Sync with Prettier * Sync with Prettier * fixing docs pics * fixing pics (#743) * fixing pics * Update package.json * fixing pics * Update docs (#785) * fixing version number * fixing env target * changing docs language * new deps (#741) * new deps * Sync with Prettier * Sync with Prettier * fixing docs pics * fixing pics (#743) * fixing pics * Update package.json * fixing pics * upgrading to 34 (#744) * upgrading to 34 * Sync with Prettier * text field value support * Sync with Prettier * Sync with Prettier * fixing tests * updating mdcweb * Update package.json * Update to v36 (#828) * Doc changes (#742) * fixing version number * fixing env target * changing docs language * new deps (#741) * new deps * Sync with Prettier * Sync with Prettier * fixing docs pics * fixing pics (#743) * fixing pics * Update package.json * fixing pics * Update docs (#785) * fixing version number * fixing env target * changing docs language * new deps (#741) * new deps * Sync with Prettier * Sync with Prettier * fixing docs pics * fixing pics (#743) * fixing pics * Update package.json * fixing pics * upgrading to 34 (#744) * upgrading to 34 * Sync with Prettier * text field value support * Sync with Prettier * Sync with Prettier * fixing tests * adding IconButton * Sync with Prettier * adding icon button * fixing screen shots * adding docs * Sync with Prettier * fixing docs * chore(package): update eslint to version 5.0.0 (#833) * Default id for TextFieldInput (#830) * Default id for TextFieldInput If showDiv is false, id is not available for TextFieldInput when id not defined in props. Generate id for both. * Update TextField.jsx
prateekbh
added a commit
to prateekbh/preact-material-components
that referenced
this pull request
Jul 14, 2018
* Release (#793) * Doc changes (#742) * fixing version number * fixing env target * changing docs language * new deps (#741) * new deps * Sync with Prettier * Sync with Prettier * fixing docs pics * fixing pics (#743) * fixing pics * Update package.json * fixing pics * Update docs (#785) * fixing version number * fixing env target * changing docs language * new deps (#741) * new deps * Sync with Prettier * Sync with Prettier * fixing docs pics * fixing pics (#743) * fixing pics * Update package.json * fixing pics * upgrading to 34 (#744) * upgrading to 34 * Sync with Prettier * text field value support * Sync with Prettier * Sync with Prettier * fixing tests * Release docs (#790) * fixing version number * fixing env target * changing docs language * new deps (#741) * new deps * Sync with Prettier * Sync with Prettier * fixing docs pics * fixing pics (#743) * fixing pics * Update package.json * fixing pics * upgrading to 34 (#744) * upgrading to 34 * Sync with Prettier * text field value support * Sync with Prettier * Sync with Prettier * fixing tests * close greenkeeper (#786) * updating to mdc 35 (#787) * updating to mdc 35 * Sync with Prettier * fixing errors and adding typography * test fix * fixing new images * Sync with Prettier * adding routes in pre-render * bug fix * test fixes * Prettierfix (#797) - optional prettier fix - hoek fix * v1.4.5 - Fixed typings for Typography. (#798) * Fix Tabs within TabBarScroller initialized multiple times (#796) * 🔥 Remove `indicator-accent` from `Tabs` component Remove `indicator-accent` from `Tabs` as it is no longer used (material-components/material-components-web#1965) * Add TabBarScrollerTabs component - `TabBarScrollerTabs` should be used within `TabBarScroller` instead of `Tabs`. - Component name is inspired by class name used by @material/mdc-tab: '.mdc-tab-bar-scroller__scroll-frame__tabs' - `scroller` property is no longer needed on `Tabs` and allows a simpler implementation - `activeTabIndex` can be used on `Tabs` and `TabBarScroller` to select active tab index * Fix prettier formatting * Uptable tabs golden screenshot * typo in import (#799) * chore(package): update webpack-cli to version 3.0.0 (#800) * Update @material/rtl to the latest version 🚀 (#801) * fix(package): update @material/rtl to version 0.36.0 * Sync with Prettier * Don't bundle a copy of Preact into dist (#826) * Update index.js * Updating deps (#827) * Doc changes (#742) * fixing version number * fixing env target * changing docs language * new deps (#741) * new deps * Sync with Prettier * Sync with Prettier * fixing docs pics * fixing pics (#743) * fixing pics * Update package.json * fixing pics * Update docs (#785) * fixing version number * fixing env target * changing docs language * new deps (#741) * new deps * Sync with Prettier * Sync with Prettier * fixing docs pics * fixing pics (#743) * fixing pics * Update package.json * fixing pics * upgrading to 34 (#744) * upgrading to 34 * Sync with Prettier * text field value support * Sync with Prettier * Sync with Prettier * fixing tests * updating mdcweb * Update package.json * Update to v36 (#828) * Doc changes (#742) * fixing version number * fixing env target * changing docs language * new deps (#741) * new deps * Sync with Prettier * Sync with Prettier * fixing docs pics * fixing pics (#743) * fixing pics * Update package.json * fixing pics * Update docs (#785) * fixing version number * fixing env target * changing docs language * new deps (#741) * new deps * Sync with Prettier * Sync with Prettier * fixing docs pics * fixing pics (#743) * fixing pics * Update package.json * fixing pics * upgrading to 34 (#744) * upgrading to 34 * Sync with Prettier * text field value support * Sync with Prettier * Sync with Prettier * fixing tests * adding IconButton * Sync with Prettier * adding icon button * fixing screen shots * adding docs * Sync with Prettier * fixing docs * chore(package): update eslint to version 5.0.0 (#833) * Default id for TextFieldInput (#830) * Default id for TextFieldInput If showDiv is false, id is not available for TextFieldInput when id not defined in props. Generate id for both. * Update TextField.jsx * TextField improvements (#853) * Fixed missing dependency for prettier (+eslint rules) Signed-off-by: Cromefire_ <cromefirehd@gmail.com> * Added outlined to TextField Signed-off-by: Cromefire_ <cromefirehd@gmail.com> * Added outerStyle to TextField Signed-off-by: Cromefire_ <cromefirehd@gmail.com> * Fixed prettier formatting Signed-off-by: Cromefire_ <cromefirehd@gmail.com> * Switched from classProperties syntax Signed-off-by: Cromefire_ <cromefirehd@gmail.com> * Added Outlined documentation and fixed documentation link for TextField Signed-off-by: Cromefire_ <cromefirehd@gmail.com> * Added outlined sample Signed-off-by: Cromefire_ <cromefirehd@gmail.com> * Added changed images for documentation tests Signed-off-by: Cromefire_ <cromefirehd@gmail.com> * Bumped version to 1.4.7 Signed-off-by: Cromefire_ <cromefirehd@gmail.com> * updating deps (#855) * outlined select (#857) * outlined select * fixing ts defination * fixing tests * bump package.json * Fixed visible line ripple when outlined and outerStyle in case of no helper text is shown (#856) * Fixed visible line ripple when outlined Signed-off-by: Cromefire_ <cromefirehd@gmail.com> * Fixed outerStyle in case no helper text is used Signed-off-by: Cromefire_ <cromefirehd@gmail.com> * Added outerStyle documentation Signed-off-by: Cromefire_ <cromefirehd@gmail.com> * Added outerStyle documentation Signed-off-by: Cromefire_ <cromefirehd@gmail.com> * Fixed missing prop Signed-off-by: Cromefire_ <cromefirehd@gmail.com> * Fixed label name in sample Signed-off-by: Cromefire_ <cromefirehd@gmail.com> * Updated test image to new text field documentation Signed-off-by: Cromefire_ <cromefirehd@gmail.com> * Fixed outline="true" showing in <input> element Signed-off-by: Cromefire_ <cromefirehd@gmail.com> * Added helperTextOuterStyle to make styling of the wrapper around helper text and input possible Signed-off-by: Cromefire_ <cromefirehd@gmail.com> * Switched to intermediateStyle with defaults Signed-off-by: Cromefire_ <cromefirehd@gmail.com> * Made intermediateStyle optional Signed-off-by: Cromefire_ <cromefirehd@gmail.com> * Added updated textfield verification image Signed-off-by: Cromefire_ <cromefirehd@gmail.com> * Removed intermediateStyle Signed-off-by: Cromefire_ <cromefirehd@gmail.com> * Added image for changed documentation Signed-off-by: Cromefire_ <cromefirehd@gmail.com> * Removed unneeded default props Signed-off-by: Cromefire_ <cromefirehd@gmail.com> * Applied changes defined in review Signed-off-by: Cromefire_ <cromefirehd@gmail.com> * Also bumped version to 1.5.0 Signed-off-by: Cromefire_ <cromefirehd@gmail.com> * Updated textfield doc test image Signed-off-by: Cromefire_ <cromefirehd@gmail.com>
prateekbh
added a commit
to prateekbh/preact-material-components
that referenced
this pull request
Jul 23, 2018
* Release (#793) * Doc changes (#742) * fixing version number * fixing env target * changing docs language * new deps (#741) * new deps * Sync with Prettier * Sync with Prettier * fixing docs pics * fixing pics (#743) * fixing pics * Update package.json * fixing pics * Update docs (#785) * fixing version number * fixing env target * changing docs language * new deps (#741) * new deps * Sync with Prettier * Sync with Prettier * fixing docs pics * fixing pics (#743) * fixing pics * Update package.json * fixing pics * upgrading to 34 (#744) * upgrading to 34 * Sync with Prettier * text field value support * Sync with Prettier * Sync with Prettier * fixing tests * Release docs (#790) * fixing version number * fixing env target * changing docs language * new deps (#741) * new deps * Sync with Prettier * Sync with Prettier * fixing docs pics * fixing pics (#743) * fixing pics * Update package.json * fixing pics * upgrading to 34 (#744) * upgrading to 34 * Sync with Prettier * text field value support * Sync with Prettier * Sync with Prettier * fixing tests * close greenkeeper (#786) * updating to mdc 35 (#787) * updating to mdc 35 * Sync with Prettier * fixing errors and adding typography * test fix * fixing new images * Sync with Prettier * adding routes in pre-render * bug fix * test fixes * Prettierfix (#797) - optional prettier fix - hoek fix * v1.4.5 - Fixed typings for Typography. (#798) * Fix Tabs within TabBarScroller initialized multiple times (#796) * 🔥 Remove `indicator-accent` from `Tabs` component Remove `indicator-accent` from `Tabs` as it is no longer used (material-components/material-components-web#1965) * Add TabBarScrollerTabs component - `TabBarScrollerTabs` should be used within `TabBarScroller` instead of `Tabs`. - Component name is inspired by class name used by @material/mdc-tab: '.mdc-tab-bar-scroller__scroll-frame__tabs' - `scroller` property is no longer needed on `Tabs` and allows a simpler implementation - `activeTabIndex` can be used on `Tabs` and `TabBarScroller` to select active tab index * Fix prettier formatting * Uptable tabs golden screenshot * typo in import (#799) * chore(package): update webpack-cli to version 3.0.0 (#800) * Update @material/rtl to the latest version 🚀 (#801) * fix(package): update @material/rtl to version 0.36.0 * Sync with Prettier * Don't bundle a copy of Preact into dist (#826) * Update index.js * Updating deps (#827) * Doc changes (#742) * fixing version number * fixing env target * changing docs language * new deps (#741) * new deps * Sync with Prettier * Sync with Prettier * fixing docs pics * fixing pics (#743) * fixing pics * Update package.json * fixing pics * Update docs (#785) * fixing version number * fixing env target * changing docs language * new deps (#741) * new deps * Sync with Prettier * Sync with Prettier * fixing docs pics * fixing pics (#743) * fixing pics * Update package.json * fixing pics * upgrading to 34 (#744) * upgrading to 34 * Sync with Prettier * text field value support * Sync with Prettier * Sync with Prettier * fixing tests * updating mdcweb * Update package.json * Update to v36 (#828) * Doc changes (#742) * fixing version number * fixing env target * changing docs language * new deps (#741) * new deps * Sync with Prettier * Sync with Prettier * fixing docs pics * fixing pics (#743) * fixing pics * Update package.json * fixing pics * Update docs (#785) * fixing version number * fixing env target * changing docs language * new deps (#741) * new deps * Sync with Prettier * Sync with Prettier * fixing docs pics * fixing pics (#743) * fixing pics * Update package.json * fixing pics * upgrading to 34 (#744) * upgrading to 34 * Sync with Prettier * text field value support * Sync with Prettier * Sync with Prettier * fixing tests * adding IconButton * Sync with Prettier * adding icon button * fixing screen shots * adding docs * Sync with Prettier * fixing docs * chore(package): update eslint to version 5.0.0 (#833) * Default id for TextFieldInput (#830) * Default id for TextFieldInput If showDiv is false, id is not available for TextFieldInput when id not defined in props. Generate id for both. * Update TextField.jsx * TextField improvements (#853) * Fixed missing dependency for prettier (+eslint rules) Signed-off-by: Cromefire_ <cromefirehd@gmail.com> * Added outlined to TextField Signed-off-by: Cromefire_ <cromefirehd@gmail.com> * Added outerStyle to TextField Signed-off-by: Cromefire_ <cromefirehd@gmail.com> * Fixed prettier formatting Signed-off-by: Cromefire_ <cromefirehd@gmail.com> * Switched from classProperties syntax Signed-off-by: Cromefire_ <cromefirehd@gmail.com> * Added Outlined documentation and fixed documentation link for TextField Signed-off-by: Cromefire_ <cromefirehd@gmail.com> * Added outlined sample Signed-off-by: Cromefire_ <cromefirehd@gmail.com> * Added changed images for documentation tests Signed-off-by: Cromefire_ <cromefirehd@gmail.com> * Bumped version to 1.4.7 Signed-off-by: Cromefire_ <cromefirehd@gmail.com> * updating deps (#855) * outlined select (#857) * outlined select * fixing ts defination * fixing tests * bump package.json * Fixed visible line ripple when outlined and outerStyle in case of no helper text is shown (#856) * Fixed visible line ripple when outlined Signed-off-by: Cromefire_ <cromefirehd@gmail.com> * Fixed outerStyle in case no helper text is used Signed-off-by: Cromefire_ <cromefirehd@gmail.com> * Added outerStyle documentation Signed-off-by: Cromefire_ <cromefirehd@gmail.com> * Added outerStyle documentation Signed-off-by: Cromefire_ <cromefirehd@gmail.com> * Fixed missing prop Signed-off-by: Cromefire_ <cromefirehd@gmail.com> * Fixed label name in sample Signed-off-by: Cromefire_ <cromefirehd@gmail.com> * Updated test image to new text field documentation Signed-off-by: Cromefire_ <cromefirehd@gmail.com> * Fixed outline="true" showing in <input> element Signed-off-by: Cromefire_ <cromefirehd@gmail.com> * Added helperTextOuterStyle to make styling of the wrapper around helper text and input possible Signed-off-by: Cromefire_ <cromefirehd@gmail.com> * Switched to intermediateStyle with defaults Signed-off-by: Cromefire_ <cromefirehd@gmail.com> * Made intermediateStyle optional Signed-off-by: Cromefire_ <cromefirehd@gmail.com> * Added updated textfield verification image Signed-off-by: Cromefire_ <cromefirehd@gmail.com> * Removed intermediateStyle Signed-off-by: Cromefire_ <cromefirehd@gmail.com> * Added image for changed documentation Signed-off-by: Cromefire_ <cromefirehd@gmail.com> * Removed unneeded default props Signed-off-by: Cromefire_ <cromefirehd@gmail.com> * Applied changes defined in review Signed-off-by: Cromefire_ <cromefirehd@gmail.com> * Also bumped version to 1.5.0 Signed-off-by: Cromefire_ <cromefirehd@gmail.com> * Updated textfield doc test image Signed-off-by: Cromefire_ <cromefirehd@gmail.com> * fixes double body (#875) * fixes double body * Sync with Prettier * re-add diffs * re-add diffs * fixing pics * revert threashold * change wait to timeout * timeout as networkidle0 * fixing screen shots
prateekbh
added a commit
to prateekbh/preact-material-components
that referenced
this pull request
Jul 28, 2018
* Release (#793) * Doc changes (#742) * fixing version number * fixing env target * changing docs language * new deps (#741) * new deps * Sync with Prettier * Sync with Prettier * fixing docs pics * fixing pics (#743) * fixing pics * Update package.json * fixing pics * Update docs (#785) * fixing version number * fixing env target * changing docs language * new deps (#741) * new deps * Sync with Prettier * Sync with Prettier * fixing docs pics * fixing pics (#743) * fixing pics * Update package.json * fixing pics * upgrading to 34 (#744) * upgrading to 34 * Sync with Prettier * text field value support * Sync with Prettier * Sync with Prettier * fixing tests * Release docs (#790) * fixing version number * fixing env target * changing docs language * new deps (#741) * new deps * Sync with Prettier * Sync with Prettier * fixing docs pics * fixing pics (#743) * fixing pics * Update package.json * fixing pics * upgrading to 34 (#744) * upgrading to 34 * Sync with Prettier * text field value support * Sync with Prettier * Sync with Prettier * fixing tests * close greenkeeper (#786) * updating to mdc 35 (#787) * updating to mdc 35 * Sync with Prettier * fixing errors and adding typography * test fix * fixing new images * Sync with Prettier * adding routes in pre-render * bug fix * test fixes * Prettierfix (#797) - optional prettier fix - hoek fix * v1.4.5 - Fixed typings for Typography. (#798) * Fix Tabs within TabBarScroller initialized multiple times (#796) * 🔥 Remove `indicator-accent` from `Tabs` component Remove `indicator-accent` from `Tabs` as it is no longer used (material-components/material-components-web#1965) * Add TabBarScrollerTabs component - `TabBarScrollerTabs` should be used within `TabBarScroller` instead of `Tabs`. - Component name is inspired by class name used by @material/mdc-tab: '.mdc-tab-bar-scroller__scroll-frame__tabs' - `scroller` property is no longer needed on `Tabs` and allows a simpler implementation - `activeTabIndex` can be used on `Tabs` and `TabBarScroller` to select active tab index * Fix prettier formatting * Uptable tabs golden screenshot * typo in import (#799) * chore(package): update webpack-cli to version 3.0.0 (#800) * Update @material/rtl to the latest version 🚀 (#801) * fix(package): update @material/rtl to version 0.36.0 * Sync with Prettier * Don't bundle a copy of Preact into dist (#826) * Update index.js * Updating deps (#827) * Doc changes (#742) * fixing version number * fixing env target * changing docs language * new deps (#741) * new deps * Sync with Prettier * Sync with Prettier * fixing docs pics * fixing pics (#743) * fixing pics * Update package.json * fixing pics * Update docs (#785) * fixing version number * fixing env target * changing docs language * new deps (#741) * new deps * Sync with Prettier * Sync with Prettier * fixing docs pics * fixing pics (#743) * fixing pics * Update package.json * fixing pics * upgrading to 34 (#744) * upgrading to 34 * Sync with Prettier * text field value support * Sync with Prettier * Sync with Prettier * fixing tests * updating mdcweb * Update package.json * Update to v36 (#828) * Doc changes (#742) * fixing version number * fixing env target * changing docs language * new deps (#741) * new deps * Sync with Prettier * Sync with Prettier * fixing docs pics * fixing pics (#743) * fixing pics * Update package.json * fixing pics * Update docs (#785) * fixing version number * fixing env target * changing docs language * new deps (#741) * new deps * Sync with Prettier * Sync with Prettier * fixing docs pics * fixing pics (#743) * fixing pics * Update package.json * fixing pics * upgrading to 34 (#744) * upgrading to 34 * Sync with Prettier * text field value support * Sync with Prettier * Sync with Prettier * fixing tests * adding IconButton * Sync with Prettier * adding icon button * fixing screen shots * adding docs * Sync with Prettier * fixing docs * chore(package): update eslint to version 5.0.0 (#833) * Default id for TextFieldInput (#830) * Default id for TextFieldInput If showDiv is false, id is not available for TextFieldInput when id not defined in props. Generate id for both. * Update TextField.jsx * TextField improvements (#853) * Fixed missing dependency for prettier (+eslint rules) Signed-off-by: Cromefire_ <cromefirehd@gmail.com> * Added outlined to TextField Signed-off-by: Cromefire_ <cromefirehd@gmail.com> * Added outerStyle to TextField Signed-off-by: Cromefire_ <cromefirehd@gmail.com> * Fixed prettier formatting Signed-off-by: Cromefire_ <cromefirehd@gmail.com> * Switched from classProperties syntax Signed-off-by: Cromefire_ <cromefirehd@gmail.com> * Added Outlined documentation and fixed documentation link for TextField Signed-off-by: Cromefire_ <cromefirehd@gmail.com> * Added outlined sample Signed-off-by: Cromefire_ <cromefirehd@gmail.com> * Added changed images for documentation tests Signed-off-by: Cromefire_ <cromefirehd@gmail.com> * Bumped version to 1.4.7 Signed-off-by: Cromefire_ <cromefirehd@gmail.com> * updating deps (#855) * outlined select (#857) * outlined select * fixing ts defination * fixing tests * bump package.json * Fixed visible line ripple when outlined and outerStyle in case of no helper text is shown (#856) * Fixed visible line ripple when outlined Signed-off-by: Cromefire_ <cromefirehd@gmail.com> * Fixed outerStyle in case no helper text is used Signed-off-by: Cromefire_ <cromefirehd@gmail.com> * Added outerStyle documentation Signed-off-by: Cromefire_ <cromefirehd@gmail.com> * Added outerStyle documentation Signed-off-by: Cromefire_ <cromefirehd@gmail.com> * Fixed missing prop Signed-off-by: Cromefire_ <cromefirehd@gmail.com> * Fixed label name in sample Signed-off-by: Cromefire_ <cromefirehd@gmail.com> * Updated test image to new text field documentation Signed-off-by: Cromefire_ <cromefirehd@gmail.com> * Fixed outline="true" showing in <input> element Signed-off-by: Cromefire_ <cromefirehd@gmail.com> * Added helperTextOuterStyle to make styling of the wrapper around helper text and input possible Signed-off-by: Cromefire_ <cromefirehd@gmail.com> * Switched to intermediateStyle with defaults Signed-off-by: Cromefire_ <cromefirehd@gmail.com> * Made intermediateStyle optional Signed-off-by: Cromefire_ <cromefirehd@gmail.com> * Added updated textfield verification image Signed-off-by: Cromefire_ <cromefirehd@gmail.com> * Removed intermediateStyle Signed-off-by: Cromefire_ <cromefirehd@gmail.com> * Added image for changed documentation Signed-off-by: Cromefire_ <cromefirehd@gmail.com> * Removed unneeded default props Signed-off-by: Cromefire_ <cromefirehd@gmail.com> * Applied changes defined in review Signed-off-by: Cromefire_ <cromefirehd@gmail.com> * Also bumped version to 1.5.0 Signed-off-by: Cromefire_ <cromefirehd@gmail.com> * Updated textfield doc test image Signed-off-by: Cromefire_ <cromefirehd@gmail.com> * fixes double body (#875) * fixes double body * Sync with Prettier * re-add diffs * re-add diffs * fixing pics * revert threashold * change wait to timeout * timeout as networkidle0 * fixing screen shots * Card: change prop 16-9 to sixteenByNine (#868) * Card: change prop 16-9 to sixteenByNine * add className if sixteenByNine prop is present * updating deps (#879) * Update index.d.ts (#861) * fixing double render
prateekbh
added a commit
to prateekbh/preact-material-components
that referenced
this pull request
Jul 28, 2018
* Release (#793) * Doc changes (#742) * fixing version number * fixing env target * changing docs language * new deps (#741) * new deps * Sync with Prettier * Sync with Prettier * fixing docs pics * fixing pics (#743) * fixing pics * Update package.json * fixing pics * Update docs (#785) * fixing version number * fixing env target * changing docs language * new deps (#741) * new deps * Sync with Prettier * Sync with Prettier * fixing docs pics * fixing pics (#743) * fixing pics * Update package.json * fixing pics * upgrading to 34 (#744) * upgrading to 34 * Sync with Prettier * text field value support * Sync with Prettier * Sync with Prettier * fixing tests * Release docs (#790) * fixing version number * fixing env target * changing docs language * new deps (#741) * new deps * Sync with Prettier * Sync with Prettier * fixing docs pics * fixing pics (#743) * fixing pics * Update package.json * fixing pics * upgrading to 34 (#744) * upgrading to 34 * Sync with Prettier * text field value support * Sync with Prettier * Sync with Prettier * fixing tests * close greenkeeper (#786) * updating to mdc 35 (#787) * updating to mdc 35 * Sync with Prettier * fixing errors and adding typography * test fix * fixing new images * Sync with Prettier * adding routes in pre-render * bug fix * test fixes * Prettierfix (#797) - optional prettier fix - hoek fix * v1.4.5 - Fixed typings for Typography. (#798) * Fix Tabs within TabBarScroller initialized multiple times (#796) * 🔥 Remove `indicator-accent` from `Tabs` component Remove `indicator-accent` from `Tabs` as it is no longer used (material-components/material-components-web#1965) * Add TabBarScrollerTabs component - `TabBarScrollerTabs` should be used within `TabBarScroller` instead of `Tabs`. - Component name is inspired by class name used by @material/mdc-tab: '.mdc-tab-bar-scroller__scroll-frame__tabs' - `scroller` property is no longer needed on `Tabs` and allows a simpler implementation - `activeTabIndex` can be used on `Tabs` and `TabBarScroller` to select active tab index * Fix prettier formatting * Uptable tabs golden screenshot * typo in import (#799) * chore(package): update webpack-cli to version 3.0.0 (#800) * Update @material/rtl to the latest version 🚀 (#801) * fix(package): update @material/rtl to version 0.36.0 * Sync with Prettier * Don't bundle a copy of Preact into dist (#826) * Update index.js * Updating deps (#827) * Doc changes (#742) * fixing version number * fixing env target * changing docs language * new deps (#741) * new deps * Sync with Prettier * Sync with Prettier * fixing docs pics * fixing pics (#743) * fixing pics * Update package.json * fixing pics * Update docs (#785) * fixing version number * fixing env target * changing docs language * new deps (#741) * new deps * Sync with Prettier * Sync with Prettier * fixing docs pics * fixing pics (#743) * fixing pics * Update package.json * fixing pics * upgrading to 34 (#744) * upgrading to 34 * Sync with Prettier * text field value support * Sync with Prettier * Sync with Prettier * fixing tests * updating mdcweb * Update package.json * Update to v36 (#828) * Doc changes (#742) * fixing version number * fixing env target * changing docs language * new deps (#741) * new deps * Sync with Prettier * Sync with Prettier * fixing docs pics * fixing pics (#743) * fixing pics * Update package.json * fixing pics * Update docs (#785) * fixing version number * fixing env target * changing docs language * new deps (#741) * new deps * Sync with Prettier * Sync with Prettier * fixing docs pics * fixing pics (#743) * fixing pics * Update package.json * fixing pics * upgrading to 34 (#744) * upgrading to 34 * Sync with Prettier * text field value support * Sync with Prettier * Sync with Prettier * fixing tests * adding IconButton * Sync with Prettier * adding icon button * fixing screen shots * adding docs * Sync with Prettier * fixing docs * chore(package): update eslint to version 5.0.0 (#833) * Default id for TextFieldInput (#830) * Default id for TextFieldInput If showDiv is false, id is not available for TextFieldInput when id not defined in props. Generate id for both. * Update TextField.jsx * TextField improvements (#853) * Fixed missing dependency for prettier (+eslint rules) Signed-off-by: Cromefire_ <cromefirehd@gmail.com> * Added outlined to TextField Signed-off-by: Cromefire_ <cromefirehd@gmail.com> * Added outerStyle to TextField Signed-off-by: Cromefire_ <cromefirehd@gmail.com> * Fixed prettier formatting Signed-off-by: Cromefire_ <cromefirehd@gmail.com> * Switched from classProperties syntax Signed-off-by: Cromefire_ <cromefirehd@gmail.com> * Added Outlined documentation and fixed documentation link for TextField Signed-off-by: Cromefire_ <cromefirehd@gmail.com> * Added outlined sample Signed-off-by: Cromefire_ <cromefirehd@gmail.com> * Added changed images for documentation tests Signed-off-by: Cromefire_ <cromefirehd@gmail.com> * Bumped version to 1.4.7 Signed-off-by: Cromefire_ <cromefirehd@gmail.com> * updating deps (#855) * outlined select (#857) * outlined select * fixing ts defination * fixing tests * bump package.json * Fixed visible line ripple when outlined and outerStyle in case of no helper text is shown (#856) * Fixed visible line ripple when outlined Signed-off-by: Cromefire_ <cromefirehd@gmail.com> * Fixed outerStyle in case no helper text is used Signed-off-by: Cromefire_ <cromefirehd@gmail.com> * Added outerStyle documentation Signed-off-by: Cromefire_ <cromefirehd@gmail.com> * Added outerStyle documentation Signed-off-by: Cromefire_ <cromefirehd@gmail.com> * Fixed missing prop Signed-off-by: Cromefire_ <cromefirehd@gmail.com> * Fixed label name in sample Signed-off-by: Cromefire_ <cromefirehd@gmail.com> * Updated test image to new text field documentation Signed-off-by: Cromefire_ <cromefirehd@gmail.com> * Fixed outline="true" showing in <input> element Signed-off-by: Cromefire_ <cromefirehd@gmail.com> * Added helperTextOuterStyle to make styling of the wrapper around helper text and input possible Signed-off-by: Cromefire_ <cromefirehd@gmail.com> * Switched to intermediateStyle with defaults Signed-off-by: Cromefire_ <cromefirehd@gmail.com> * Made intermediateStyle optional Signed-off-by: Cromefire_ <cromefirehd@gmail.com> * Added updated textfield verification image Signed-off-by: Cromefire_ <cromefirehd@gmail.com> * Removed intermediateStyle Signed-off-by: Cromefire_ <cromefirehd@gmail.com> * Added image for changed documentation Signed-off-by: Cromefire_ <cromefirehd@gmail.com> * Removed unneeded default props Signed-off-by: Cromefire_ <cromefirehd@gmail.com> * Applied changes defined in review Signed-off-by: Cromefire_ <cromefirehd@gmail.com> * Also bumped version to 1.5.0 Signed-off-by: Cromefire_ <cromefirehd@gmail.com> * Updated textfield doc test image Signed-off-by: Cromefire_ <cromefirehd@gmail.com> * fixes double body (#875) * fixes double body * Sync with Prettier * re-add diffs * re-add diffs * fixing pics * revert threashold * change wait to timeout * timeout as networkidle0 * fixing screen shots * Card: change prop 16-9 to sixteenByNine (#868) * Card: change prop 16-9 to sixteenByNine * add className if sixteenByNine prop is present * updating deps (#879) * Update index.d.ts (#861) * fixing double render * fixing golden docs
prateekbh
added a commit
to prateekbh/preact-material-components
that referenced
this pull request
Aug 15, 2018
* Release (#793) * Doc changes (#742) * fixing version number * fixing env target * changing docs language * new deps (#741) * new deps * Sync with Prettier * Sync with Prettier * fixing docs pics * fixing pics (#743) * fixing pics * Update package.json * fixing pics * Update docs (#785) * fixing version number * fixing env target * changing docs language * new deps (#741) * new deps * Sync with Prettier * Sync with Prettier * fixing docs pics * fixing pics (#743) * fixing pics * Update package.json * fixing pics * upgrading to 34 (#744) * upgrading to 34 * Sync with Prettier * text field value support * Sync with Prettier * Sync with Prettier * fixing tests * Release docs (#790) * fixing version number * fixing env target * changing docs language * new deps (#741) * new deps * Sync with Prettier * Sync with Prettier * fixing docs pics * fixing pics (#743) * fixing pics * Update package.json * fixing pics * upgrading to 34 (#744) * upgrading to 34 * Sync with Prettier * text field value support * Sync with Prettier * Sync with Prettier * fixing tests * close greenkeeper (#786) * updating to mdc 35 (#787) * updating to mdc 35 * Sync with Prettier * fixing errors and adding typography * test fix * fixing new images * Sync with Prettier * adding routes in pre-render * bug fix * test fixes * Prettierfix (#797) - optional prettier fix - hoek fix * v1.4.5 - Fixed typings for Typography. (#798) * Fix Tabs within TabBarScroller initialized multiple times (#796) * 🔥 Remove `indicator-accent` from `Tabs` component Remove `indicator-accent` from `Tabs` as it is no longer used (material-components/material-components-web#1965) * Add TabBarScrollerTabs component - `TabBarScrollerTabs` should be used within `TabBarScroller` instead of `Tabs`. - Component name is inspired by class name used by @material/mdc-tab: '.mdc-tab-bar-scroller__scroll-frame__tabs' - `scroller` property is no longer needed on `Tabs` and allows a simpler implementation - `activeTabIndex` can be used on `Tabs` and `TabBarScroller` to select active tab index * Fix prettier formatting * Uptable tabs golden screenshot * typo in import (#799) * chore(package): update webpack-cli to version 3.0.0 (#800) * Update @material/rtl to the latest version 🚀 (#801) * fix(package): update @material/rtl to version 0.36.0 * Sync with Prettier * Don't bundle a copy of Preact into dist (#826) * Update index.js * Updating deps (#827) * Doc changes (#742) * fixing version number * fixing env target * changing docs language * new deps (#741) * new deps * Sync with Prettier * Sync with Prettier * fixing docs pics * fixing pics (#743) * fixing pics * Update package.json * fixing pics * Update docs (#785) * fixing version number * fixing env target * changing docs language * new deps (#741) * new deps * Sync with Prettier * Sync with Prettier * fixing docs pics * fixing pics (#743) * fixing pics * Update package.json * fixing pics * upgrading to 34 (#744) * upgrading to 34 * Sync with Prettier * text field value support * Sync with Prettier * Sync with Prettier * fixing tests * updating mdcweb * Update package.json * Update to v36 (#828) * Doc changes (#742) * fixing version number * fixing env target * changing docs language * new deps (#741) * new deps * Sync with Prettier * Sync with Prettier * fixing docs pics * fixing pics (#743) * fixing pics * Update package.json * fixing pics * Update docs (#785) * fixing version number * fixing env target * changing docs language * new deps (#741) * new deps * Sync with Prettier * Sync with Prettier * fixing docs pics * fixing pics (#743) * fixing pics * Update package.json * fixing pics * upgrading to 34 (#744) * upgrading to 34 * Sync with Prettier * text field value support * Sync with Prettier * Sync with Prettier * fixing tests * adding IconButton * Sync with Prettier * adding icon button * fixing screen shots * adding docs * Sync with Prettier * fixing docs * chore(package): update eslint to version 5.0.0 (#833) * Default id for TextFieldInput (#830) * Default id for TextFieldInput If showDiv is false, id is not available for TextFieldInput when id not defined in props. Generate id for both. * Update TextField.jsx * TextField improvements (#853) * Fixed missing dependency for prettier (+eslint rules) Signed-off-by: Cromefire_ <cromefirehd@gmail.com> * Added outlined to TextField Signed-off-by: Cromefire_ <cromefirehd@gmail.com> * Added outerStyle to TextField Signed-off-by: Cromefire_ <cromefirehd@gmail.com> * Fixed prettier formatting Signed-off-by: Cromefire_ <cromefirehd@gmail.com> * Switched from classProperties syntax Signed-off-by: Cromefire_ <cromefirehd@gmail.com> * Added Outlined documentation and fixed documentation link for TextField Signed-off-by: Cromefire_ <cromefirehd@gmail.com> * Added outlined sample Signed-off-by: Cromefire_ <cromefirehd@gmail.com> * Added changed images for documentation tests Signed-off-by: Cromefire_ <cromefirehd@gmail.com> * Bumped version to 1.4.7 Signed-off-by: Cromefire_ <cromefirehd@gmail.com> * updating deps (#855) * outlined select (#857) * outlined select * fixing ts defination * fixing tests * bump package.json * Fixed visible line ripple when outlined and outerStyle in case of no helper text is shown (#856) * Fixed visible line ripple when outlined Signed-off-by: Cromefire_ <cromefirehd@gmail.com> * Fixed outerStyle in case no helper text is used Signed-off-by: Cromefire_ <cromefirehd@gmail.com> * Added outerStyle documentation Signed-off-by: Cromefire_ <cromefirehd@gmail.com> * Added outerStyle documentation Signed-off-by: Cromefire_ <cromefirehd@gmail.com> * Fixed missing prop Signed-off-by: Cromefire_ <cromefirehd@gmail.com> * Fixed label name in sample Signed-off-by: Cromefire_ <cromefirehd@gmail.com> * Updated test image to new text field documentation Signed-off-by: Cromefire_ <cromefirehd@gmail.com> * Fixed outline="true" showing in <input> element Signed-off-by: Cromefire_ <cromefirehd@gmail.com> * Added helperTextOuterStyle to make styling of the wrapper around helper text and input possible Signed-off-by: Cromefire_ <cromefirehd@gmail.com> * Switched to intermediateStyle with defaults Signed-off-by: Cromefire_ <cromefirehd@gmail.com> * Made intermediateStyle optional Signed-off-by: Cromefire_ <cromefirehd@gmail.com> * Added updated textfield verification image Signed-off-by: Cromefire_ <cromefirehd@gmail.com> * Removed intermediateStyle Signed-off-by: Cromefire_ <cromefirehd@gmail.com> * Added image for changed documentation Signed-off-by: Cromefire_ <cromefirehd@gmail.com> * Removed unneeded default props Signed-off-by: Cromefire_ <cromefirehd@gmail.com> * Applied changes defined in review Signed-off-by: Cromefire_ <cromefirehd@gmail.com> * Also bumped version to 1.5.0 Signed-off-by: Cromefire_ <cromefirehd@gmail.com> * Updated textfield doc test image Signed-off-by: Cromefire_ <cromefirehd@gmail.com> * fixes double body (#875) * fixes double body * Sync with Prettier * re-add diffs * re-add diffs * fixing pics * revert threashold * change wait to timeout * timeout as networkidle0 * fixing screen shots * Card: change prop 16-9 to sixteenByNine (#868) * Card: change prop 16-9 to sixteenByNine * add className if sixteenByNine prop is present * updating deps (#879) * Update index.d.ts (#861) * fixing double render * fixing golden docs * Fixed imports in TopAppBar demo (#916) * Fixed imports in TopAppBar demo * updated the reference image * Improve build system (#878) * Added yarn.lock to .gitignore to open a PR changes are required * Added basic typescript infrastructure and moved switch to typescript * Sync with Prettier * Readded webpack build * Set target to es2015 and removed webpack again * Migrated MaterialComponent and set up tslint * Let typescript transpile jsx syntax * Added updated .ignores * Added typescript parser for prettier * Reverted parser change * Excluding future build artifacts * Added babel for transpiling * Added babel options * Fixed travis doc test to fail, if no failed images are generated * Improved failing if compile failed * Updated babel version * Fixed compile fail detection * Migrated Typography * Migrated TopAppBar * Migrated Toolbar * Sync with Prettier * Migrated TextField * Migrated Tabs and added linting to test * Migrated Snackbar and Slider * Migrated Select * Migrated Radio * Migrated Menu and List * Sync with Prettier * Migrated LineRipple * Migrated LinearProgress and LayoutGrid * Migrated ImageList * Migrated IconButton, IconToggle and Icon and added types for mwc * Migrated GridList, FormField, Fab and Elevation * Sync with Prettier * Migrated Drawer, Dialog, Chips, Checkbox, Card and Button * Fixed wrong references * Fixed lint issues and readded webpack to build * Fixed type issue with html elements * Added autogeneration of /Component/index.d.ts and started using autobind for Component classes * Excluded declarations from git and prettier * Removed accidental autobind-decorator from docs * Implemented autobind * Fixed tslint style * Added tslint fixer * Fixed test script * Sync with Prettier * Remove still tracked js file Signed-off-by: Cromefire_ <cromefirehd@gmail.com> * Fixed missing props and children Signed-off-by: Cromefire_ <cromefirehd@gmail.com> * Set typescript to strict mode Signed-off-by: Cromefire_ <cromefirehd@gmail.com> * Fixed Select Page Signed-off-by: Cromefire_ <cromefirehd@gmail.com> * Sync with Prettier * Fixed sample Signed-off-by: Cromefire_ <cromefirehd@gmail.com> * Fixed sample Signed-off-by: Cromefire_ <cromefirehd@gmail.com> * Cleared TODOs Signed-off-by: Cromefire_ <cromefirehd@gmail.com> * Fixed componentWillUnmount() for IconButton Signed-off-by: Cromefire_ <cromefirehd@gmail.com> * Integrated primary and secondary into MaterialComponent Signed-off-by: Cromefire_ <cromefirehd@gmail.com> * Sync with Prettier * Revert "Integrated primary and secondary into MaterialComponent" This reverts commit a5498b9 Signed-off-by: Cromefire_ <cromefirehd@gmail.com> * Migrated primary and secondary back to Button and Fab Signed-off-by: Cromefire_ <cromefirehd@gmail.com> * Fixed props in materialDom() Signed-off-by: Cromefire_ <cromefirehd@gmail.com> * Fixed LinearProgress themeProp declaration Signed-off-by: Cromefire_ <cromefirehd@gmail.com> * Added disables to IconButtons mdcProps Signed-off-by: Cromefire_ <cromefirehd@gmail.com> * Fixed /index in import Signed-off-by: Cromefire_ <cromefirehd@gmail.com> * Fixed /index in import in .js files Signed-off-by: Cromefire_ <cromefirehd@gmail.com> * Fixed IconButton props Signed-off-by: Cromefire_ <cromefirehd@gmail.com> * Fixed type for onChange Signed-off-by: Cromefire_ <cromefirehd@gmail.com> * Fixed props and added TODOs for mismatching ones Signed-off-by: Cromefire_ <cromefirehd@gmail.com> * removing sample * fixing a few props * bumping version * dont compile sample * fixing select * fixing tests * Fixed types.d.ts not in generated output and switched from this.base to this.control in Select and Switch Fixes #918 Signed-off-by: Cromefire_ <cromefirehd@gmail.com> * Fixed TextFieldProps becase TextField is not a MDComponent Signed-off-by: Cromefire_ <cromefirehd@gmail.com> * Letting babel only run once Signed-off-by: Cromefire_ <cromefirehd@gmail.com> * Added babel runtime Signed-off-by: Cromefire_ <cromefirehd@gmail.com> * Updated .ignore Files Signed-off-by: Cromefire_ <tim.l@nghorst.net> * Excluded .babelrc, .prettierignore and .eslintignore from npm package Signed-off-by: Cromefire_ <tim.l@nghorst.net> * Update to38 (#919) * updating deps * added deprecation notice * Fix code typo on homepage (#917) The wrong package is being imported. * Make the two card demos look different (#870) * Added valid to TextFieldProps (#920) * Added valid to TextFieldProps Signed-off-by: Cromefire_ <tim.l@nghorst.net> * Sync with Prettier * Changes for38 (#923) * fixing list and switch * implementing tab-bar * bug fix * Sync with Prettier * re-order * Fixed style * resolving comments * adding css file * Sync with Prettier * fixing golden tests * fixing golden test * Adjusting docs for 1.5.1 (#924) * Added changelog for 1.5.1 Signed-off-by: Cromefire_ <tim.l@nghorst.net> * Sync with Prettier * Updated README for 1.5.1 Signed-off-by: Cromefire_ <tim.l@nghorst.net> * Added new build system to doc page and implemented Fire Code for code Signed-off-by: Cromefire_ <tim.l@nghorst.net> * Fixed Tab bar page code Signed-off-by: Cromefire_ <tim.l@nghorst.net> * Fixed TabBar page typo Signed-off-by: Cromefire_ <tim.l@nghorst.net> * Set font display to swap Signed-off-by: Cromefire_ <tim.l@nghorst.net> * Removed component list from README * Updated test images Signed-off-by: Cromefire_ <tim.l@nghorst.net> * chore(package): update eslint-config-prettier to version 3.0.0 (#925)
prateekbh
added a commit
to prateekbh/preact-material-components
that referenced
this pull request
Sep 5, 2018
* Release (#793) * Doc changes (#742) * fixing version number * fixing env target * changing docs language * new deps (#741) * new deps * Sync with Prettier * Sync with Prettier * fixing docs pics * fixing pics (#743) * fixing pics * Update package.json * fixing pics * Update docs (#785) * fixing version number * fixing env target * changing docs language * new deps (#741) * new deps * Sync with Prettier * Sync with Prettier * fixing docs pics * fixing pics (#743) * fixing pics * Update package.json * fixing pics * upgrading to 34 (#744) * upgrading to 34 * Sync with Prettier * text field value support * Sync with Prettier * Sync with Prettier * fixing tests * Release docs (#790) * fixing version number * fixing env target * changing docs language * new deps (#741) * new deps * Sync with Prettier * Sync with Prettier * fixing docs pics * fixing pics (#743) * fixing pics * Update package.json * fixing pics * upgrading to 34 (#744) * upgrading to 34 * Sync with Prettier * text field value support * Sync with Prettier * Sync with Prettier * fixing tests * close greenkeeper (#786) * updating to mdc 35 (#787) * updating to mdc 35 * Sync with Prettier * fixing errors and adding typography * test fix * fixing new images * Sync with Prettier * adding routes in pre-render * bug fix * test fixes * Prettierfix (#797) - optional prettier fix - hoek fix * v1.4.5 - Fixed typings for Typography. (#798) * Fix Tabs within TabBarScroller initialized multiple times (#796) * 🔥 Remove `indicator-accent` from `Tabs` component Remove `indicator-accent` from `Tabs` as it is no longer used (material-components/material-components-web#1965) * Add TabBarScrollerTabs component - `TabBarScrollerTabs` should be used within `TabBarScroller` instead of `Tabs`. - Component name is inspired by class name used by @material/mdc-tab: '.mdc-tab-bar-scroller__scroll-frame__tabs' - `scroller` property is no longer needed on `Tabs` and allows a simpler implementation - `activeTabIndex` can be used on `Tabs` and `TabBarScroller` to select active tab index * Fix prettier formatting * Uptable tabs golden screenshot * typo in import (#799) * chore(package): update webpack-cli to version 3.0.0 (#800) * Update @material/rtl to the latest version 🚀 (#801) * fix(package): update @material/rtl to version 0.36.0 * Sync with Prettier * Don't bundle a copy of Preact into dist (#826) * Update index.js * Updating deps (#827) * Doc changes (#742) * fixing version number * fixing env target * changing docs language * new deps (#741) * new deps * Sync with Prettier * Sync with Prettier * fixing docs pics * fixing pics (#743) * fixing pics * Update package.json * fixing pics * Update docs (#785) * fixing version number * fixing env target * changing docs language * new deps (#741) * new deps * Sync with Prettier * Sync with Prettier * fixing docs pics * fixing pics (#743) * fixing pics * Update package.json * fixing pics * upgrading to 34 (#744) * upgrading to 34 * Sync with Prettier * text field value support * Sync with Prettier * Sync with Prettier * fixing tests * updating mdcweb * Update package.json * Update to v36 (#828) * Doc changes (#742) * fixing version number * fixing env target * changing docs language * new deps (#741) * new deps * Sync with Prettier * Sync with Prettier * fixing docs pics * fixing pics (#743) * fixing pics * Update package.json * fixing pics * Update docs (#785) * fixing version number * fixing env target * changing docs language * new deps (#741) * new deps * Sync with Prettier * Sync with Prettier * fixing docs pics * fixing pics (#743) * fixing pics * Update package.json * fixing pics * upgrading to 34 (#744) * upgrading to 34 * Sync with Prettier * text field value support * Sync with Prettier * Sync with Prettier * fixing tests * adding IconButton * Sync with Prettier * adding icon button * fixing screen shots * adding docs * Sync with Prettier * fixing docs * chore(package): update eslint to version 5.0.0 (#833) * Default id for TextFieldInput (#830) * Default id for TextFieldInput If showDiv is false, id is not available for TextFieldInput when id not defined in props. Generate id for both. * Update TextField.jsx * TextField improvements (#853) * Fixed missing dependency for prettier (+eslint rules) Signed-off-by: Cromefire_ <cromefirehd@gmail.com> * Added outlined to TextField Signed-off-by: Cromefire_ <cromefirehd@gmail.com> * Added outerStyle to TextField Signed-off-by: Cromefire_ <cromefirehd@gmail.com> * Fixed prettier formatting Signed-off-by: Cromefire_ <cromefirehd@gmail.com> * Switched from classProperties syntax Signed-off-by: Cromefire_ <cromefirehd@gmail.com> * Added Outlined documentation and fixed documentation link for TextField Signed-off-by: Cromefire_ <cromefirehd@gmail.com> * Added outlined sample Signed-off-by: Cromefire_ <cromefirehd@gmail.com> * Added changed images for documentation tests Signed-off-by: Cromefire_ <cromefirehd@gmail.com> * Bumped version to 1.4.7 Signed-off-by: Cromefire_ <cromefirehd@gmail.com> * updating deps (#855) * outlined select (#857) * outlined select * fixing ts defination * fixing tests * bump package.json * Fixed visible line ripple when outlined and outerStyle in case of no helper text is shown (#856) * Fixed visible line ripple when outlined Signed-off-by: Cromefire_ <cromefirehd@gmail.com> * Fixed outerStyle in case no helper text is used Signed-off-by: Cromefire_ <cromefirehd@gmail.com> * Added outerStyle documentation Signed-off-by: Cromefire_ <cromefirehd@gmail.com> * Added outerStyle documentation Signed-off-by: Cromefire_ <cromefirehd@gmail.com> * Fixed missing prop Signed-off-by: Cromefire_ <cromefirehd@gmail.com> * Fixed label name in sample Signed-off-by: Cromefire_ <cromefirehd@gmail.com> * Updated test image to new text field documentation Signed-off-by: Cromefire_ <cromefirehd@gmail.com> * Fixed outline="true" showing in <input> element Signed-off-by: Cromefire_ <cromefirehd@gmail.com> * Added helperTextOuterStyle to make styling of the wrapper around helper text and input possible Signed-off-by: Cromefire_ <cromefirehd@gmail.com> * Switched to intermediateStyle with defaults Signed-off-by: Cromefire_ <cromefirehd@gmail.com> * Made intermediateStyle optional Signed-off-by: Cromefire_ <cromefirehd@gmail.com> * Added updated textfield verification image Signed-off-by: Cromefire_ <cromefirehd@gmail.com> * Removed intermediateStyle Signed-off-by: Cromefire_ <cromefirehd@gmail.com> * Added image for changed documentation Signed-off-by: Cromefire_ <cromefirehd@gmail.com> * Removed unneeded default props Signed-off-by: Cromefire_ <cromefirehd@gmail.com> * Applied changes defined in review Signed-off-by: Cromefire_ <cromefirehd@gmail.com> * Also bumped version to 1.5.0 Signed-off-by: Cromefire_ <cromefirehd@gmail.com> * Updated textfield doc test image Signed-off-by: Cromefire_ <cromefirehd@gmail.com> * fixes double body (#875) * fixes double body * Sync with Prettier * re-add diffs * re-add diffs * fixing pics * revert threashold * change wait to timeout * timeout as networkidle0 * fixing screen shots * Card: change prop 16-9 to sixteenByNine (#868) * Card: change prop 16-9 to sixteenByNine * add className if sixteenByNine prop is present * updating deps (#879) * Update index.d.ts (#861) * fixing double render * fixing golden docs * Fixed imports in TopAppBar demo (#916) * Fixed imports in TopAppBar demo * updated the reference image * Improve build system (#878) * Added yarn.lock to .gitignore to open a PR changes are required * Added basic typescript infrastructure and moved switch to typescript * Sync with Prettier * Readded webpack build * Set target to es2015 and removed webpack again * Migrated MaterialComponent and set up tslint * Let typescript transpile jsx syntax * Added updated .ignores * Added typescript parser for prettier * Reverted parser change * Excluding future build artifacts * Added babel for transpiling * Added babel options * Fixed travis doc test to fail, if no failed images are generated * Improved failing if compile failed * Updated babel version * Fixed compile fail detection * Migrated Typography * Migrated TopAppBar * Migrated Toolbar * Sync with Prettier * Migrated TextField * Migrated Tabs and added linting to test * Migrated Snackbar and Slider * Migrated Select * Migrated Radio * Migrated Menu and List * Sync with Prettier * Migrated LineRipple * Migrated LinearProgress and LayoutGrid * Migrated ImageList * Migrated IconButton, IconToggle and Icon and added types for mwc * Migrated GridList, FormField, Fab and Elevation * Sync with Prettier * Migrated Drawer, Dialog, Chips, Checkbox, Card and Button * Fixed wrong references * Fixed lint issues and readded webpack to build * Fixed type issue with html elements * Added autogeneration of /Component/index.d.ts and started using autobind for Component classes * Excluded declarations from git and prettier * Removed accidental autobind-decorator from docs * Implemented autobind * Fixed tslint style * Added tslint fixer * Fixed test script * Sync with Prettier * Remove still tracked js file Signed-off-by: Cromefire_ <cromefirehd@gmail.com> * Fixed missing props and children Signed-off-by: Cromefire_ <cromefirehd@gmail.com> * Set typescript to strict mode Signed-off-by: Cromefire_ <cromefirehd@gmail.com> * Fixed Select Page Signed-off-by: Cromefire_ <cromefirehd@gmail.com> * Sync with Prettier * Fixed sample Signed-off-by: Cromefire_ <cromefirehd@gmail.com> * Fixed sample Signed-off-by: Cromefire_ <cromefirehd@gmail.com> * Cleared TODOs Signed-off-by: Cromefire_ <cromefirehd@gmail.com> * Fixed componentWillUnmount() for IconButton Signed-off-by: Cromefire_ <cromefirehd@gmail.com> * Integrated primary and secondary into MaterialComponent Signed-off-by: Cromefire_ <cromefirehd@gmail.com> * Sync with Prettier * Revert "Integrated primary and secondary into MaterialComponent" This reverts commit a5498b9 Signed-off-by: Cromefire_ <cromefirehd@gmail.com> * Migrated primary and secondary back to Button and Fab Signed-off-by: Cromefire_ <cromefirehd@gmail.com> * Fixed props in materialDom() Signed-off-by: Cromefire_ <cromefirehd@gmail.com> * Fixed LinearProgress themeProp declaration Signed-off-by: Cromefire_ <cromefirehd@gmail.com> * Added disables to IconButtons mdcProps Signed-off-by: Cromefire_ <cromefirehd@gmail.com> * Fixed /index in import Signed-off-by: Cromefire_ <cromefirehd@gmail.com> * Fixed /index in import in .js files Signed-off-by: Cromefire_ <cromefirehd@gmail.com> * Fixed IconButton props Signed-off-by: Cromefire_ <cromefirehd@gmail.com> * Fixed type for onChange Signed-off-by: Cromefire_ <cromefirehd@gmail.com> * Fixed props and added TODOs for mismatching ones Signed-off-by: Cromefire_ <cromefirehd@gmail.com> * removing sample * fixing a few props * bumping version * dont compile sample * fixing select * fixing tests * Fixed types.d.ts not in generated output and switched from this.base to this.control in Select and Switch Fixes #918 Signed-off-by: Cromefire_ <cromefirehd@gmail.com> * Fixed TextFieldProps becase TextField is not a MDComponent Signed-off-by: Cromefire_ <cromefirehd@gmail.com> * Letting babel only run once Signed-off-by: Cromefire_ <cromefirehd@gmail.com> * Added babel runtime Signed-off-by: Cromefire_ <cromefirehd@gmail.com> * Updated .ignore Files Signed-off-by: Cromefire_ <tim.l@nghorst.net> * Excluded .babelrc, .prettierignore and .eslintignore from npm package Signed-off-by: Cromefire_ <tim.l@nghorst.net> * Update to38 (#919) * updating deps * added deprecation notice * Fix code typo on homepage (#917) The wrong package is being imported. * Make the two card demos look different (#870) * Added valid to TextFieldProps (#920) * Added valid to TextFieldProps Signed-off-by: Cromefire_ <tim.l@nghorst.net> * Sync with Prettier * Changes for38 (#923) * fixing list and switch * implementing tab-bar * bug fix * Sync with Prettier * re-order * Fixed style * resolving comments * adding css file * Sync with Prettier * fixing golden tests * fixing golden test * Adjusting docs for 1.5.1 (#924) * Added changelog for 1.5.1 Signed-off-by: Cromefire_ <tim.l@nghorst.net> * Sync with Prettier * Updated README for 1.5.1 Signed-off-by: Cromefire_ <tim.l@nghorst.net> * Added new build system to doc page and implemented Fire Code for code Signed-off-by: Cromefire_ <tim.l@nghorst.net> * Fixed Tab bar page code Signed-off-by: Cromefire_ <tim.l@nghorst.net> * Fixed TabBar page typo Signed-off-by: Cromefire_ <tim.l@nghorst.net> * Set font display to swap Signed-off-by: Cromefire_ <tim.l@nghorst.net> * Removed component list from README * Updated test images Signed-off-by: Cromefire_ <tim.l@nghorst.net> * chore(package): update eslint-config-prettier to version 3.0.0 (#925) * Delegated MDComponent notification to MaterialComponent Signed-off-by: Cromefire_ <tim.l@nghorst.net> * Added value to TextField notify props Signed-off-by: Cromefire_ <tim.l@nghorst.net> * Fixed value notify prop on TextField Signed-off-by: Cromefire_ <tim.l@nghorst.net> * Added fixed value prop to TextField Signed-off-by: Cromefire_ <tim.l@nghorst.net> * Removed unneeded setValid Signed-off-by: Cromefire_ <tim.l@nghorst.net> * Added disabled notification to Checkbox Signed-off-by: Cromefire_ <tim.l@nghorst.net> * Added babel runtime as runtime dependecy (#922) * Added babel runtime as runtime dependecy * Sync with Prettier * Also update classText on update Signed-off-by: Cromefire_ <tim.l@nghorst.net> * Reverted to reversed Signed-off-by: Cromefire_ <tim.l@nghorst.net> * Only conditionally rebuilding className Signed-off-by: Cromefire_ <tim.l@nghorst.net> * Published 1.5.1-experimental2 from the right branch and removed docs and .idea from npm package Signed-off-by: Cromefire_ <tim.l@nghorst.net> * Removed debug log Signed-off-by: Cromefire_ <tim.l@nghorst.net> * Removed MDComponent hasOwnProperty check Signed-off-by: Cromefire_ <tim.l@nghorst.net> * Fixed disabled prop accidentally removed from element Signed-off-by: Cromefire_ <tim.l@nghorst.net> * experimental4 Signed-off-by: Cromefire_ <tim.l@nghorst.net> * Fixed className generation on update Signed-off-by: Cromefire_ <tim.l@nghorst.net> * Fixed className generation for TextField Signed-off-by: Cromefire_ <tim.l@nghorst.net> * Sync with Prettier * renamed reverse prop in docs back to reversed Signed-off-by: Cromefire_ <tim.l@nghorst.net> * Fixed some last minor issues Signed-off-by: Cromefire_ <tim.l@nghorst.net> * Making requested changes Signed-off-by: Cromefire_ <tim.l@nghorst.net> * Removed value notification Signed-off-by: Cromefire_ <tim.l@nghorst.net> * Added active notification for Tab Signed-off-by: Cromefire_ <tim.l@nghorst.net> * Released experimental 7 Signed-off-by: Cromefire_ <tim.l@nghorst.net> * Improved TypeScript typing for soft merge (See #970) Signed-off-by: Cromefire_ <tim.l@nghorst.net> * Updated version to 1.5.1 Signed-off-by: Cromefire_ <tim.l@nghorst.net>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial fix of: #1152
TODO: Update README.md to reflect changes