Skip to content
This repository has been archived by the owner on Jan 13, 2025. It is now read-only.

fix(list item): Add overflow hidden #1290

Merged
merged 4 commits into from
Oct 3, 2017

Conversation

cluelessjoe
Copy link
Contributor

Resolves #1261
Done through mdc-typography-overflow-ellipsis mixin

Resolves material-components#1261
Done through mdc-typography-overflow-ellipsis mixin
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
  • In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

@cluelessjoe
Copy link
Contributor Author

I signed the CLA
On top of it, screenshot before/after the bug fix:
beforebugfix
afterbugfix
I continue the discussion in #1261

@googlebot
Copy link

CLAs look good, thanks!

@lynnmercier
Copy link
Contributor

You've got some lint errors still. Looks like it wants you to add an empty line between the @include and the next line

@lynnmercier lynnmercier self-assigned this Sep 22, 2017
@codecov-io
Copy link

codecov-io commented Oct 3, 2017

Codecov Report

Merging #1290 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1290   +/-   ##
=======================================
  Coverage   99.91%   99.91%           
=======================================
  Files          69       69           
  Lines        3381     3381           
  Branches      421      421           
=======================================
  Hits         3378     3378           
  Misses          3        3

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ccead5f...027f109. Read the comment docs.

@lynnmercier lynnmercier merged commit 05b1201 into material-components:master Oct 3, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants