Setting theme colors for a light text on a dark background cause mdc-card to be unreadable #930

lynnmercier · 2017-07-11T16:57:34Z

What MDC-Web Version are you using?

Version 0.14.0

What are the steps to reproduce the bug?

https://codepen.io/ZhugeSong/pen/WOyoBz

What is the expected behavior?

Card should be readable

What is the actual behavior?

Card uses the light text on a white background, making it illegible.

Any other information you believe would be useful?

Discussion about theming leads us to believe mdc-card should use text-primary-on-light instead of text-primary-on-background, since background can be light or dark.

Closes #930

lynnmercier added the backlog label Jul 11, 2017

lynnmercier mentioned this issue Jul 11, 2017

fix(card): Text in a card should use text-primary-on-light #931

Merged

yeelan0319 closed this as completed in #931 Jul 13, 2017

yeelan0319 pushed a commit that referenced this issue Jul 13, 2017

fix(card): Correct text in a card to use text-primar-on-light (#931)

e3966d9

Closes #930

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Setting theme colors for a light text on a dark background cause mdc-card to be unreadable #930

Setting theme colors for a light text on a dark background cause mdc-card to be unreadable #930

lynnmercier commented Jul 11, 2017

Setting theme colors for a light text on a dark background cause mdc-card to be unreadable #930

Setting theme colors for a light text on a dark background cause mdc-card to be unreadable #930

Comments

lynnmercier commented Jul 11, 2017

What MDC-Web Version are you using?

What are the steps to reproduce the bug?

What is the expected behavior?

What is the actual behavior?

Any other information you believe would be useful?