Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove computeIndicatorClientRect from mdc-tab adapter #3341

Closed
moog16 opened this issue Aug 13, 2018 · 0 comments
Closed

Remove computeIndicatorClientRect from mdc-tab adapter #3341

moog16 opened this issue Aug 13, 2018 · 0 comments
Labels
backlog

Comments

@moog16
Copy link
Contributor

moog16 commented Aug 13, 2018

Within mdc-tab's adapter is a method computeIndicatorClientRect. This is only called once from within the foundation, which just returns the adapter method. It is an unnecessary round trip, which can be removed.

This computeIndicatorClientRect should be a public method on the component.
lynnmercier added a commit that referenced this issue Aug 16, 2018
@lynnmercier
chore(tab): Move computeIndicatorClientRect logic out of the foundation
28dc72b 
Resolves #3341
@lynnmercier lynnmercier mentioned this issue Aug 16, 2018
Merged
lynnmercier added a commit that referenced this issue Aug 16, 2018
@lynnmercier
chore(tab): Move computeIndicatorClientRect logic out of the foundati…
9cac7c0 
…on (#3367)

Resolves #3341

BREAKING CHANGE: We've removed the `computeIndicatorClientRect` method from `MDCTabFoundation`
williamernest pushed a commit that referenced this issue Aug 20, 2018
@lynnmercier @williamernest
chore(tab): Move computeIndicatorClientRect logic out of the foundati…
f91e185 
…on (#3367)

Resolves #3341

BREAKING CHANGE: We've removed the `computeIndicatorClientRect` method from `MDCTabFoundation`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
backlog
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kfranqueiro @moog16