This repository has been archived by the owner on Jan 13, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Incorrect class name used for mdc-toolbar-fixed-adjust #320
Comments
ghost
mentioned this issue
Feb 21, 2017
This actually seems like it's a bug in our toolbar code. That class should be |
traviskaufman
changed the title
Typos in the documentation of mdc toolbar
Incorrect class name used for mdc-toolbar-fixed-adjust
Feb 21, 2017
Provided a PR #321 . |
traviskaufman
pushed a commit
that referenced
this issue
Feb 21, 2017
cristobalchao
pushed a commit
that referenced
this issue
Feb 24, 2017
It seems that you did not update CSS file before publishing mdc-toolbar@0.1.1 SCSS file's class name was updated, but CSS file was not. 😢 $ cat node_modules/@material/toolbar/package.json | ack version
"version": "0.1.1"
$ cat node_modules/@material/toolbar/dist/mdc.toolbar.css | ack mdc-toolbar
.mdc-toolbar {
.mdc-toolbar {
.mdc-toolbar__section {
.mdc-toolbar__section--align-start {
.mdc-toolbar__section--align-end {
.mdc-toolbar__section .mdc-toolbar__title {
.mdc-toolbar--fixed {
.mdc-toolbar__fixed-adjust {
.mdc-toolbar__fixed-adjust {
$ cat node_modules/@material/toolbar/mdc-toolbar.scss | ack mdc-toolbar
$mdc-toolbar-height: 64px;
$mdc-toolbar-mobile-height: 56px;
$mdc-toolbar-padding: 24px 16px;
$mdc-toolbar-mobile-padding: 16px;
$mdc-toolbar-mobile-breakpoint: 599px;
.mdc-toolbar {
height: $mdc-toolbar-height;
padding: $mdc-toolbar-padding;
@media (max-width: $mdc-toolbar-mobile-breakpoint) {
height: $mdc-toolbar-mobile-height;
padding: $mdc-toolbar-mobile-padding;
.mdc-toolbar__title {
.mdc-toolbar--fixed {
.mdc-toolbar-fixed-adjust {
margin-top: $mdc-toolbar-height;
margin-top: $mdc-toolbar-mobile-height; |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
What MDC-Web Version are you using?
v0.5.0
What browser(s) is this bug affecting?
Every.
What OS are you using?
4.9.9-1-ARCH
What are the steps to reproduce the bug?
Follow the fixed toolbar documentation.
What is the expected behavior?
Add top margin to the siblings of the fixed toolbar.
What is the actual behavior?
No added margin caused by two typos in the documentation.
Any other information you believe would be useful?
I can quickly provide a pull request to fix this.
The text was updated successfully, but these errors were encountered: