fix(text-field): Adjust the baseline of text field's helper text to match spec #3069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3069 +/- ##
==========================================
+ Coverage 98.24% 98.35% +0.11%
==========================================
Files 120 120
Lines 5129 5118 -11
Branches 638 638
==========================================
- Hits 5039 5034 -5
+ Misses 90 84 -6
Continue to review full report at Codecov.
|
abhiomkar
changed the title
|
🤖 Beep boop! Screenshot test reportCommit b132601 vs. No diffs! 💯🎉 |
kfranqueiro
suggested changes
Jul 30, 2018
demos/text-field.html
Outdated
| aria-hidden="true" style="display:none;"> | ||
| Helper Text (possibly validation message) | ||
| aria-hidden="true" style="display:none;" | ||
| >Helper Text (possibly validation message) |
There was a problem hiding this comment.
Why is the helper text sensitive to leading whitespace now? AFAICT it was not previously?
If this is a limitation of the new baseline styles/mixin, I'd like to see us work it out if at all possible...
kfranqueiro
approved these changes
Aug 1, 2018
| <p id="username-helper-text" class="mdc-text-field-helper-text" aria-hidden="true"> | ||
| This will be displayed on your public profile | ||
| </p> | ||
| <p id="username-helper-text" class="mdc-text-field-helper-text" aria-hidden="true">This will be displayed on your public profile</p> |
There was a problem hiding this comment.
I guess this formatting change can be reverted?
…xt_baseline_issue2783
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2783
BREAKING CHANGE
Changes included: