Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(button): Restore order of disabled styles #1176

Merged
merged 1 commit into from
Aug 23, 2017

Conversation

kfranqueiro
Copy link
Contributor

Fixes #1167 by moving disabled styles back to the end of mdc-button.scss.

Also reorganizes test page to allow testing disabled state on all button types.

Copy link
Contributor

@acdvorak acdvorak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@codecov-io
Copy link

codecov-io commented Aug 23, 2017

Codecov Report

Merging #1176 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1176   +/-   ##
======================================
  Coverage    99.9%   99.9%           
======================================
  Files          69      69           
  Lines        3305    3305           
  Branches      405     405           
======================================
  Hits         3302    3302           
  Misses          3       3

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a24bca...0508beb. Read the comment docs.

@kfranqueiro kfranqueiro merged commit 6ffed49 into master Aug 23, 2017
@kfranqueiro kfranqueiro deleted the fix/button-primary-disabled branch August 23, 2017 18:45
@acdvorak acdvorak self-assigned this Aug 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants