Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update checkbox color to secondary color #1146

Closed
2 of 5 tasks
lynnmercier opened this issue Aug 17, 2017 · 0 comments
Closed
2 of 5 tasks

Update checkbox color to secondary color #1146

lynnmercier opened this issue Aug 17, 2017 · 0 comments
Labels
backlog
Milestone
Theme Improvements

Comments

@lynnmercier
Copy link
Contributor

lynnmercier commented Aug 17, 2017 •
edited by acdvorak
Loading

  • Create color mixins
  • Call color mixin from stylesheet, with secondary color
  • Update README to document color mixins
  • Delete any --primary --accent modifiers
  • Include "breaking change" message about removing modifiers, point to color mixin as deprecation replacement.
@lynnmercier lynnmercier added this to the Theme Improvements milestone Aug 17, 2017
@acdvorak acdvorak changed the title Update checkbox color to primary color Update checkbox color to secondary color Oct 11, 2017
@acdvorak acdvorak mentioned this issue Oct 11, 2017
Merged
acdvorak added a commit that referenced this issue Oct 11, 2017
@acdvorak
feat(checkbox): Add color theme mixins and update default color to se…
cc7538f 
…condary (#1365)

- Removed `[aria-disabled="true"]` selector, as it doesn't appear to be necessary
- Fixed preexisting state transition color animation bugs

Resolves #1146
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
backlog
Projects
None yet
Milestone
Theme Improvements
Development

No branches or pull requests
1 participant
@lynnmercier