added implementations #399
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mateacademy-ai-mentor
approved these changes
Nov 1, 2024
There was a problem hiding this comment.
Great job on implementing the classes and meeting the task requirements! 🎉 The code is well-structured and follows the specifications. Just a small suggestion: ensure that the super() call in the ArticlePage constructor passes the url parameter to properly initialize the parent class. Keep up the good work and happy coding! 😊
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
Comment on lines
+20
to
+21
| constructor(url, slug) { | ||
| super(); |
There was a problem hiding this comment.
The super() call in the ArticlePage constructor should pass the url parameter to the PageObject constructor. This ensures that the url property is correctly initialized in the parent class. Consider changing super(); to super(url);.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.