Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solution #397

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Solution #397

wants to merge 1 commit into from

Conversation

vs-qaaug
Copy link

No description provided.

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job on the implementation! 🎉 The issues mentioned are minor and don't impact the functionality of your code. Keep up the good work, and consider addressing the formatting issue for better readability in the future.

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

Comment on lines +20 to +22
constructor(url, slug) {
super(url);
this.url = url + slug;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The constructor in the ArticlePage class should modify the original url by adding slug at the end. Currently, it reassigns this.url to url + slug, which is correct. Ensure that this behavior aligns with the task requirements.

}

assertPageOpened() {
return 'The ' + this.url + ' is opened';

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a minor formatting issue in the assertPageOpened method. The returned string should have a space before 'is opened'. It should be 'The ' + this.url + ' is opened'.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants