-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dev #6109
base: master
Are you sure you want to change the base?
Dev #6109
Changes from 8 commits
75181e4
c41283d
634b077
c60d305
14bd8a7
8630938
9d8d9f5
e1bf70f
d3b69d5
4482470
833728a
e62b081
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,29 @@ | ||
name: Test | ||
|
||
on: | ||
pull_request: | ||
branches: [ master ] | ||
|
||
jobs: | ||
build: | ||
|
||
runs-on: ubuntu-latest | ||
|
||
strategy: | ||
matrix: | ||
node-version: [20.x] | ||
|
||
steps: | ||
- uses: actions/checkout@v2 | ||
- name: Use Node.js ${{ matrix.node-version }} | ||
uses: actions/setup-node@v1 | ||
with: | ||
node-version: ${{ matrix.node-version }} | ||
- run: npm install | ||
- run: npm test | ||
- name: Upload HTML report(backstop data) | ||
if: ${{ always() }} | ||
uses: actions/upload-artifact@v2 | ||
with: | ||
name: report | ||
path: backstop_data |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -11,12 +11,105 @@ | |
content="ie=edge" | ||
/> | ||
<title>Moyo header</title> | ||
<link | ||
rel="preconnect" | ||
href="https://fonts.googleapis.com" | ||
/> | ||
<link | ||
rel="preconnect" | ||
href="https://fonts.gstatic.com" | ||
crossorigin="anonymous" | ||
/> | ||
<link | ||
href="https://fonts.googleapis.com/css2?family=Roboto:wght@500&display=swap" | ||
rel="stylesheet" | ||
/> | ||
<link | ||
rel="stylesheet" | ||
href="./style.css" | ||
/> | ||
</head> | ||
<body> | ||
<header class="header"> | ||
<a | ||
class="logo" | ||
href="index.html" | ||
> | ||
<img | ||
src="/src/images/logo.png" | ||
alt="logo" | ||
/> | ||
</a> | ||
<nav class="nav"> | ||
<ul class="nav__list"> | ||
<li> | ||
<a | ||
class="nav__link is-active" | ||
href="#" | ||
Comment on lines
+50
to
+52
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The link's |
||
> | ||
apple | ||
</a> | ||
</li> | ||
<li> | ||
<a | ||
class="nav__link returned" | ||
href="#" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Similar to the previous comment, ensure that the |
||
> | ||
samsung | ||
</a> | ||
</li> | ||
<li> | ||
<a | ||
class="nav__link returned" | ||
href="#" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Ensure that the |
||
> | ||
smartphones | ||
</a> | ||
</li> | ||
<li> | ||
<a | ||
class="nav__link returned" | ||
data-qa="hover" | ||
href="#" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The |
||
> | ||
laptops & computers | ||
</a> | ||
</li> | ||
<li> | ||
<a | ||
class="nav__link returned" | ||
href="#" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Ensure that the |
||
> | ||
gadgets | ||
</a> | ||
</li> | ||
<li> | ||
<a | ||
class="nav__link returned" | ||
href="#" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Ensure that the |
||
> | ||
tablets | ||
</a> | ||
</li> | ||
<li> | ||
<a | ||
class="nav__link returned" | ||
href="#" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Ensure that the |
||
> | ||
photo | ||
</a> | ||
</li> | ||
<li> | ||
<a | ||
class="nav__link returned" | ||
href="#" | ||
Comment on lines
+107
to
+109
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Ensure that the |
||
> | ||
video | ||
</a> | ||
</li> | ||
</ul> | ||
</nav> | ||
</header> | ||
<h1>Moyo header</h1> | ||
</body> | ||
</html> |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,80 @@ | ||
body { | ||
* { | ||
margin: 0; | ||
padding: 0; | ||
} | ||
|
||
html { | ||
font-family: Roboto, serif; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The task requires using only the Roboto font with specific settings. The inclusion of |
||
font-optical-sizing: auto; | ||
font-weight: 500; | ||
font-style: normal; | ||
font-variation-settings: 'wdth' 100; | ||
|
||
--blue: #00acdc; | ||
} | ||
|
||
.header { | ||
display: flex; | ||
box-sizing: border-box; | ||
flex-direction: row; | ||
justify-content: flex-end; | ||
width: 100%; | ||
min-width: 1024px; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The use of |
||
align-items: center; | ||
background-color: #fff; | ||
padding-right: 50px; | ||
} | ||
|
||
h1 { | ||
margin: 30px; | ||
} | ||
|
||
.logo { | ||
display: inline-block; | ||
position: absolute; | ||
width: 40px; | ||
height: 40px; | ||
left: 50px; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The |
||
} | ||
|
||
.nav__list { | ||
display: flex; | ||
flex-direction: row; | ||
list-style-type: none; | ||
align-content: flex-end; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The |
||
} | ||
|
||
.nav__link { | ||
height: 60px; | ||
line-height: 60px; | ||
text-transform: uppercase; | ||
display: inline-block; | ||
text-decoration: none; | ||
font-size: 12px; | ||
color: #000; | ||
} | ||
|
||
.nav__link:hover { | ||
color: var(--blue); | ||
} | ||
|
||
.is-active { | ||
position: relative; | ||
display: inline-block; | ||
color: var(--blue); | ||
} | ||
|
||
.is-active::after { | ||
content: ''; | ||
position: absolute; | ||
left: 0; | ||
bottom: 0; | ||
width: 100%; | ||
height: 4px; | ||
background: var(--blue); | ||
border-radius: 8px; | ||
} | ||
|
||
.returned { | ||
margin-left: 20px; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider adding
aria-label
ortitle
attribute to the logo link for better accessibility, as it currently only contains an image.