Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add solution #6108

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

valchuk-ivan
Copy link

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your hard work on this project! 😊 While your code is well-structured and follows many best practices, there are a few critical issues that need to be addressed to fully meet the task requirements. Specifically, the font weight specified in the task is not correctly implemented, a CSS variable for the blue color is missing, and the header height should be derived from the nav links rather than being fixed. Additionally, the logo should be wrapped in a link, and CSS should be used to display text in uppercase instead of directly using uppercase text in HTML. Lastly, consider avoiding the use of the * selector for better performance. Once these issues are resolved, your solution will be ready for approval. Keep up the great work! 🚀

✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨

🔄 Fix the issues, commit the changes, and then re-request my review using the Re-request review button in the Reviewers tab.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants