Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Why it's already done? #109

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Why it's already done? #109

wants to merge 3 commits into from

Conversation

Karanelus
Copy link

Task was already done in initial repo, but it was the solution what i have in mind =D

Zibi95
Zibi95 suggested changes Sep 16, 2024
View reviewed changes
Copy link

@Zibi95 Zibi95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey this task is about wrting a tests for this function.

Write tests for a function arrayReverse

@Karanelus Karanelus requested a review from Zibi95 September 16, 2024 10:46
natalia-klonowska
natalia-klonowska suggested changes Sep 16, 2024
View reviewed changes
Copy link

@natalia-klonowska natalia-klonowska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you should also check string with special symbols and array with only one string

BogdanMaliuta
BogdanMaliuta approved these changes Sep 16, 2024
View reviewed changes
Copy link

@BogdanMaliuta BogdanMaliuta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its nice, but I think you need to check also function declaration and arguments

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BogdanMaliuta BogdanMaliuta BogdanMaliuta approved these changes

@Zibi95 Zibi95 Awaiting requested review from Zibi95

@natalia-klonowska natalia-klonowska Awaiting requested review from natalia-klonowska

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Karanelus @Zibi95 @natalia-klonowska @BogdanMaliuta